Re: [DynInst_API:] spack dyninst/package.py file changes?

[Benjamin Welton <welton@xxxxxxxxxxx>]

Mark,

Packages.yaml is site/user specific (at least as per my understanding). 

> Spack will take the latest version from intel-tbb by default.  

I do not believe this is true. Spack will only do this if no version of TBB was installed by spack already. If a site has the oldest version of TBB supported by spack already installed, that will be used with Dyninst (likely something we dont want). 

Jim, if you want to give it a try my suggested changes are the following (if these work, then it is likely good to submit to spack as a pull request):

TBB Package.py:

version('2018.6', ' 9a0f78db4f72356068b00f29f54ee6bc')  

Dyninst Package.py:

depends_on("tbb@2018.6:")

(then your other changes).

As for going forward, I am going to suggest on Monday that we (dyninst) keeps a running github fork of spack where we make changes to the packages for dyninst. That way we have a single location that we can grant access to and allow for commits/testing before submitting a pull request to the main spack repo.

Ben

On Sun, Nov 4, 2018 at 1:24 PM Mark W. Krentel <krentel@xxxxxxxx> wrote:

I know that dyninst will download and build TBB, elfutils, boost if
they're not specified.  That's fine that you go the extra mile, but
that's not the spack way of doing things.

Spack wants to build all the prereqs itself, through the intel-tbb
package.py file.  (So, it's important to allow -D vars for all the
external prereqs.)

As for version, I suggest you leave this unspecified in the dyninst
recipe.  Just use depends_on('tbb').  This is what the packages.yaml
file is for.

Spack will take the latest version from intel-tbb by default.  So
unless there's some version that's completely incompatible, I suggest
don't add unnecessary constraints.  Let someone specify this in
packages.yaml.

Of course, if you want to update the intel-tbb recipe, that's fine,
but that's a separate question.

Btw, I was planning on making a pass over the dyninst recipe, but I'm
waiting for 10.x to be tagged and released.

--Mark


On 11/04/18 08:33, Xiaozhu Meng wrote:
> Hi Ben,
>
> Dyninst will automatically download the following version of TBB:
>
> URL https://github.com/01org/tbb/archive/2018_U6.tar.gz
> URL_MD5 9a0f78db4f72356068b00f29f54ee6bc
>
> It looks like this version is not in your TBB version list. Is the
> above not supported by spack?
>
> Thanks,
>
> --Xiaozhu
>