Re: [DynInst_API:] spack dyninst/package.py file changes?

["Mark W. Krentel" <krentel@xxxxxxxx>]

I know that dyninst will download and build TBB, elfutils, boost if
they're not specified.  That's fine that you go the extra mile, but
that's not the spack way of doing things.

Spack wants to build all the prereqs itself, through the intel-tbb
package.py file.  (So, it's important to allow -D vars for all the
external prereqs.)

As for version, I suggest you leave this unspecified in the dyninst
recipe.  Just use depends_on('tbb').  This is what the packages.yaml
file is for.

Spack will take the latest version from intel-tbb by default.  So
unless there's some version that's completely incompatible, I suggest
don't add unnecessary constraints.  Let someone specify this in
packages.yaml.

Of course, if you want to update the intel-tbb recipe, that's fine,
but that's a separate question.

Btw, I was planning on making a pass over the dyninst recipe, but I'm
waiting for 10.x to be tagged and released.

--Mark


On 11/04/18 08:33, Xiaozhu Meng wrote:
> Hi Ben,
>
> Dyninst will automatically download the following version of TBB:
>
> URL https://github.com/01org/tbb/archive/2018_U6.tar.gz
> URL_MD5 9a0f78db4f72356068b00f29f54ee6bc
>
> It looks like this version is not in your TBB version list. Is the 
> above not supported by spack?
> Thanks,
>
> --Xiaozhu