Re: [DynInst_API:] COMMIT: InstructionAPI Integer Multiply

[Josh Stone <jistone@xxxxxxxxxx>]

On 03/25/2015 12:22 PM, Alexander Morris wrote:
> This commit fixes the handling of AL/AX in 8-bit unsigned multiplication
> for x86. Previously, both registers were marked as being written,
> leading to errors in symbolic evaluation. This commit no longer marks AL
> as written.

If I may make a suggestion, for everyone -- it would be useful to have a
full description in the git commit message too.  Yours looks like:

> commit 80b7f806d0b9b97a32cfa2c12fb50617d165d3c8
> Author: Alex Morris <amorris@xxxxxxxxxxx>
> Date:   Wed Mar 25 14:14:57 2015 -0500
> 
>     InstructionAPI Integer Multiply
>     This commit fixes the handling of AL/AX in 8-bit unsigned multiplication.

That's almost the same sentence you started with above, but the rest of
what you wrote is useful to know too, else you wouldn't have written it.
 If you ever have to look back and see why a change was made, having
complete information directly in git really helps.

If everyone starts writing complete commit messages, then you could even
replace these manually-emailed notifications with a git hook script,
sending emails immediately after every push.

Also, more of a nit, a lot of git tools parse the commit summary from
the first paragraph, not just the first line.  So you'd need a blank
line after your "subject" line to make that work properly.

Thanks,
Josh