[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Condor-devel] nmi_submit failing to load windows profile?
- Date: Fri, 16 Jul 2010 09:20:29 -0500
- From: Dan Bradley <dan@xxxxxxxxxxxx>
- Subject: [Condor-devel] nmi_submit failing to load windows profile?
I happened to notice the following line in condor_nmi_submit. I think
this line is wrong.
print $fh "+load_profile = true\n";
The problem is that the submit file command is named "load_profile" but
the ClassAd attribute is named "LoadProfile". Therefore, I don't think
the above line will have the desired effect.
Does anybody know if this is important to the way the windows builds are
intended to work?
The reason the +LoadProfile form needs to be used instead of the
load_profile submit command is that the submit command is only supported
by the windows version of condor_submit. I think that should be
changed. We support cross-platform submits, so there is no reason to
restrict the use of this command to the windows version of
condor_submit. In fact, I just received a support ticket from someone
who wants to submit jobs from unix to windows with this option turned
on. I will tell them to set it via +LoadProfile, but I think we should
also remove the ifdef around this feature in condor_submit. Any
disagreement?
Below is the original commit where this line appeared. It appears to be
related to the following gittrack issues:
https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=571
https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=1267
commit 3226270f11b02cebdbaf55af651968c3820e1389
Author: Ben Burnett <burnett@xxxxxxxxxxx>
Date: Wed Apr 1 18:58:06 2009 -0500
Added a line to force Windows builds to load the slot user's profile.
diff --git a/nmi_tools/condor_nmi_submit b/nmi_tools/condor_nmi_submit
index 15bc2c7..f1cd35b 100755
--- a/nmi_tools/condor_nmi_submit
+++ b/nmi_tools/condor_nmi_submit
@@ -1065,6 +1065,8 @@ sub writeCommonInfo
print $fh "configure = $opt_configure\n";
}
+ print $fh "+load_profile = true\n";
+
print $fh "platforms = " . join(', ', @platforms) . "\n";
}
Cheers,
--Dan