Re: [Condor-devel] MyString::GetCStr deprecated

[Matthew Farrellee <matt@xxxxxxxxxx>]

Erik Paulson wrote:
> On Wed, Feb 25, 2009 at 10:29:02AM -0600, Peter Keller wrote:
> > > For starters, why is it "My" string?  Does this mean that nobody wants to
> > > claim responsibility for writing this class?
> > The excitable Professor Basney, who wrote MyProxy, easily takes credit for
> > what he wrote, so I don't think your claim is valid.
>
> MyString.h, v1.1, was checked in by Adiel.
>
> -Erik

Basney's only contribution to MyString.h was...

commit 7b97d8feefc6def57e1e32ed6c58dc799a7dae87
Author: jbasney <jbasney>
Date:   Mon Nov 23 17:15:17 1998 +0000

    set capacity correctly in all cases

diff --git a/src/condor_c++_util/MyString.h b/src/condor_c++_util/MyString.h
index a557988..60702bf 100644
--- a/src/condor_c++_util/MyString.h
+++ b/src/condor_c++_util/MyString.h
@@ -59,6 +59,7 @@ public:

   MyString(const MyString& S) {
     Data=NULL;
+       capacity = 0;
     *this=S;
   }

@@ -115,6 +116,7 @@ public:
       Len=S.Len;
       Data=new char[Len+1];
       strcpy(Data,S.Data);
+         capacity = Len;
     }
     return *this;
   }

...and is only 1 of the 15 people who have played with the file.

Best,


matt