Re: [Condor-devel] MyString::GetCStr deprecated

[Dan Bradley <dan@xxxxxxxxxxxx>]

Interesting.  It seems that our class "YourInsensitiveString" is not as 
insensitive as some other people's string classes.  Perhaps this is 
because we have better adult supervision?

I am reminded of a wise remark from Todd (always on the front lines when 
it comes to adult supervision).  He said that when we hire people, we 
should really be focusing on how well they can _read_ code.  How true.  
And in all fairness, before they decide to jump in, the candidate should 
really be given a full dose of the mess!

--Dan

Douglas Thain wrote:
> This article seems relevant to the discussion.
> See about the third paragraph from the end.
>
> http://www.joelonsoftware.com/articles/fog0000000069.html
>
>
> On Mon, Feb 23, 2009 at 5:19 PM, Peter Keller <psilord@xxxxxxxxxxx> wrote:
>   
> > On Mon, Feb 23, 2009 at 04:14:39PM -0600, Greg Thain wrote:
> >     
> > > Having been bitten by the crazy semantics of MyString::GetCStr, I
> > > decided this weekend to just remove it from our code.  I've removed all
> > > uses of GetCStr (many of which were potential core-dumps), and made the
> > > MyString::GetCStr method private.  There were a handful of cases where
> > > we were relying on the odd semantics, so those cases are now more
> > > explicit.   I realize this may cause some merge conflicts when fixing
> > > 7.2 bugs, but it will be worth it in the long run.
> > >       
> > Awesome! Thanks!
> >
> > -pete
> > _______________________________________________
> > Condor-devel mailing list
> > Condor-devel@xxxxxxxxxxx
> > https://lists.cs.wisc.edu/mailman/listinfo/condor-devel
> >
> >     
> _______________________________________________
> Condor-devel mailing list
> Condor-devel@xxxxxxxxxxx
> https://lists.cs.wisc.edu/mailman/listinfo/condor-devel
>