HTCondor Project List Archives



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Condor-devel] please use unified diffs for all condor-related patches



Whenever attaching a patch to an email, gnats ticket, NMI issue, etc, etc, please use a unified diff (-u) and use the -p option to tell diff to indicate what function the diff is in at the top of each hunk.

so:

diff -up old new > patch.txt

or just:

cvs diff -up > patch.txt


The resulting patch.txt will be much easier to read and review than anything else. And, mail readers that do funny things with '>' for indentation won't be confused, since diff will just use '+' and '-' to tell you what was added or removed.

Thanks,
-Derek

p.s. For cvs diff, you can also just put this in your ~/.cvsrc file:

diff -up

and then CVS will always use those arguments when you invoke "cvs diff"