Re: [Condor-devel] debian support

[guillaume pernot <gpernot@xxxxxxxxxxx>]

hi,

Le mercredi 25 octobre 2006 10:35, guillaume pernot a écrit :
> > If everything builds and passes, you're done!
> 
> hum, nearly :( for both gcc and g++ :
> job_rsc_getdirentries_std                (returned 255)
> 
> any clue for this one ?

hum, in fact, the test routine is bogus !

the attached patch clean-up testdir so that consecutive calls won't fail 
on "directory exists"...

foobaz:~/src/pool/condor/src/condor_tests$ ./batch_test.pl -d gcc -t 
job_rsc_getdirentries_std
submitting gcc tests .
job_rsc_getdirentries_std                succeeded

1 successful, 0 failed
foobaz:~/src/pool/condor/src/condor_tests$ ./batch_test.pl -d gcc -t 
job_rsc_getdirentries_std
submitting gcc tests .
job_rsc_getdirentries_std                succeeded

1 successful, 0 failed
foobaz:~/src/pool/condor/src/condor_tests$ ./batch_test.pl -d g++ -t 
job_rsc_getdirentries_std
submitting g++ tests .
job_rsc_getdirentries_std                succeeded

1 successful, 0 failed
foobaz:~/src/pool/condor/src/condor_tests$ ./batch_test.pl -d g++ -t 
job_rsc_getdirentries_std
submitting g++ tests .
job_rsc_getdirentries_std                succeeded

1 successful, 0 failed


regards,
-- 
guillaume pernot
http://www.praksys.org - Midi-Pyrénées et Aquitaine
Membre du réseau Libre Entreprise
GPG fingerprint : D356 5318 CE52 64C9 0CEF

=== modified file 'src/condor_tests/job_rsc_getdirentries_std.c'
--- src/condor_tests/job_rsc_getdirentries_std.c	2006-10-17 15:28:36 +0000
+++ src/condor_tests/job_rsc_getdirentries_std.c	2006-10-25 09:08:09 +0000
@@ -151,6 +151,27 @@
 		window = (DENT *)voidstar;
 	}
 	close(fd);
+
+	results = unlink("testdir/first");
+	if(results == -1) {
+		perror("unlink testdir/first");
+		return -1;
+	}
+	results = unlink("testdir/second");
+	if(results == -1) {
+		perror("unlink testdir/second");
+		return -1;
+	}
+	results = unlink("testdir/third");
+	if(results == -1) {
+		perror("unlink testdir/third");
+		return -1;
+	}
+	results = rmdir("testdir");
+	if(results == -1) {
+		perror("unlink testdir");
+		return -1;
+	}
 	
 	/* this is not a transitive boolean, because it implies I found
 		_certain_ expected files. */