[DynInst_API:] [dyninst/dyninst] b75907: Extract DynCFGFactory

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/extract_refactor_parsing
  Home:   https://github.com/dyninst/dyninst
  Commit: b75907b42ac3acc22e19df4ccee2e3bf4a0bdc84
      https://github.com/dyninst/dyninst/commit/b75907b42ac3acc22e19df4ccee2e3bf4a0bdc84
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/image.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/parsing/CMakeLists.txt
    A dyninstAPI/src/parsing/DynCFGFactory.C
    A dyninstAPI/src/parsing/DynCFGFactory.h
    M dyninstAPI/src/parsing/Parsing.C
    M dyninstAPI/src/parsing/Parsing.h

  Log Message:
  -----------
  Extract DynCFGFactory


  Commit: 23d47defe537886217aa0d66acd8c8232de6568d
      https://github.com/dyninst/dyninst/commit/23d47defe537886217aa0d66acd8c8232de6568d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Remove dead code


  Commit: 431660e24af6e627080a524b7a9aef0cbed75084
      https://github.com/dyninst/dyninst/commit/431660e24af6e627080a524b7a9aef0cbed75084
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Remove allocation stats

These are unused debugging checks.


  Commit: 8acabe18e971593b1466e016ce1ce8f1d41550b4
      https://github.com/dyninst/dyninst/commit/8acabe18e971593b1466e016ce1ce8f1d41550b4
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: Clean up mkblock


  Commit: f90cd809d388d2ce58451f9ae8d92582a28998d1
      https://github.com/dyninst/dyninst/commit/f90cd809d388d2ce58451f9ae8d92582a28998d1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: use boost::lock_guard


  Commit: a7288e75b75d5c531cc43dff8d32534236e373c6
      https://github.com/dyninst/dyninst/commit/a7288e75b75d5c531cc43dff8d32534236e373c6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify 'st' initialization


  Commit: 297766cf3cf2297d484d74f7248de370e4317fe7
      https://github.com/dyninst/dyninst/commit/297766cf3cf2297d484d74f7248de370e4317fe7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify pdmod calculation


  Commit: f02779183c3a5be9bca128103fb72efacc8b05d0
      https://github.com/dyninst/dyninst/commit/f02779183c3a5be9bca128103fb72efacc8b05d0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify return flow


  Commit: f4fbe5eb30b794912e3c24952566aecf9c83b942
      https://github.com/dyninst/dyninst/commit/f4fbe5eb30b794912e3c24952566aecf9c83b942
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Inline ctor


  Commit: 816a69835146fe3841ff2e960277c102e6e51216
      https://github.com/dyninst/dyninst/commit/816a69835146fe3841ff2e960277c102e6e51216
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: explicitly default dtor

This still suppresses compiler declarations of copy/move operations.


  Commit: 09f3b5aa921b4f4958169501757329cd69e8b4df
      https://github.com/dyninst/dyninst/commit/09f3b5aa921b4f4958169501757329cd69e8b4df
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mksink cleanup


  Commit: 50d9605f2e1edd0581622252a2d559addc10c87f
      https://github.com/dyninst/dyninst/commit/50d9605f2e1edd0581622252a2d559addc10c87f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/image.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/mapped_object.C
    M dyninstAPI/src/parsing/CMakeLists.txt
    A dyninstAPI/src/parsing/DynParseCallback.C
    A dyninstAPI/src/parsing/DynParseCallback.h
    M dyninstAPI/src/parsing/Parsing.C
    M dyninstAPI/src/parsing/Parsing.h

  Log Message:
  -----------
  Extract DynParseCallback

This also inlines codeBytesUpdateCB.


  Commit: 505e6826bf6ef39ae957386a44b5195a79107a6f
      https://github.com/dyninst/dyninst/commit/505e6826bf6ef39ae957386a44b5195a79107a6f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/BPatch/BPatch_addressSpace.C
    M dyninstAPI/src/BPatch/BPatch_edge.C
    M dyninstAPI/src/hybridCallbacks.C
    M dyninstAPI/src/image.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/mapped_object.C
    M dyninstAPI/src/mapped_object.h
    M dyninstAPI/src/parsing/CMakeLists.txt
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/Parsing-arch.C
    R dyninstAPI/src/parsing/Parsing.C
    R dyninstAPI/src/parsing/Parsing.h
    M dyninstAPI/src/parsing/parse_func.C
    M dyninstAPI/src/parsing/parse_func.h
    M dyninstAPI/src/patching/function.C

  Log Message:
  -----------
  Remove Parsing.{h,C}

They aren't needed anymore.


  Commit: 60295c05df88e7c79843f416b15792dfe4ea80ac
      https://github.com/dyninst/dyninst/commit/60295c05df88e7c79843f416b15792dfe4ea80ac
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/CMakeLists.txt
    M dyninstAPI/src/parsing/DynParseCallback.C
    M dyninstAPI/src/parsing/DynParseCallback.h
    R dyninstAPI/src/parsing/Parsing-arch.C
    M dyninstAPI/src/parsing/parse_func.h

  Log Message:
  -----------
  Extract DynParseCallback::instruction_cb

There's no need to have a compile guard for it.


Compare: https://github.com/dyninst/dyninst/compare/691c5efe84f4...60295c05df88

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications