[DynInst_API:] [dyninst/dyninst] fb6b56: Extract DynCFGFactory

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/extract_refactor_parsing
  Home:   https://github.com/dyninst/dyninst
  Commit: fb6b56be53b5fe80f375a1d0673a559f4929ca31
      https://github.com/dyninst/dyninst/commit/fb6b56be53b5fe80f375a1d0673a559f4929ca31
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/image.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/parsing/CMakeLists.txt
    A dyninstAPI/src/parsing/DynCFGFactory.C
    A dyninstAPI/src/parsing/DynCFGFactory.h
    M dyninstAPI/src/parsing/Parsing.C
    M dyninstAPI/src/parsing/Parsing.h

  Log Message:
  -----------
  Extract DynCFGFactory


  Commit: 80a45013c7cf6c9a0394606c3a2700d509c04b38
      https://github.com/dyninst/dyninst/commit/80a45013c7cf6c9a0394606c3a2700d509c04b38
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Remove dead code


  Commit: 67a46687baf1a8c3fb771a93a58ec4483ddb99d9
      https://github.com/dyninst/dyninst/commit/67a46687baf1a8c3fb771a93a58ec4483ddb99d9
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Remove allocation stats

These are unused debugging checks.


  Commit: 759b2c4369c6dd926fa1761bdc4b6ee6fab26647
      https://github.com/dyninst/dyninst/commit/759b2c4369c6dd926fa1761bdc4b6ee6fab26647
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: Clean up mkblock


  Commit: 54e4742e1861ea8a06506649e0f44e6776031a7e
      https://github.com/dyninst/dyninst/commit/54e4742e1861ea8a06506649e0f44e6776031a7e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: use boost::lock_guard


  Commit: f5a0779249dc0e1a5ff50f34d854b79f267f0a89
      https://github.com/dyninst/dyninst/commit/f5a0779249dc0e1a5ff50f34d854b79f267f0a89
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify 'st' initialization


  Commit: 8c687a4561e8c484281d157cb17fde4b793fb02c
      https://github.com/dyninst/dyninst/commit/8c687a4561e8c484281d157cb17fde4b793fb02c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify pdmod calculation


  Commit: 8dd3f54cdafbb8ecd39f5b075fc2fac09a2c5eca
      https://github.com/dyninst/dyninst/commit/8dd3f54cdafbb8ecd39f5b075fc2fac09a2c5eca
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mkfunc: simplify return flow


  Commit: 1f589de9b37e52666e3574a5d41d9fc3956a1c95
      https://github.com/dyninst/dyninst/commit/1f589de9b37e52666e3574a5d41d9fc3956a1c95
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: Inline ctor


  Commit: c76b595d7c143f3f16b8c0c9b6aaf619f3645487
      https://github.com/dyninst/dyninst/commit/c76b595d7c143f3f16b8c0c9b6aaf619f3645487
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.h

  Log Message:
  -----------
  DynCFGFactory: explicitly default dtor

This still suppresses compiler declarations of copy/move operations.


  Commit: 7229daad1765cb82f534eb2f3921fa5ad4ef974d
      https://github.com/dyninst/dyninst/commit/7229daad1765cb82f534eb2f3921fa5ad4ef974d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/DynCFGFactory.C

  Log Message:
  -----------
  DynCFGFactory: mksink cleanup


  Commit: c4503504fc67ba5701a6cc803068f264837db606
      https://github.com/dyninst/dyninst/commit/c4503504fc67ba5701a6cc803068f264837db606
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/image.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/mapped_object.C
    M dyninstAPI/src/parsing/CMakeLists.txt
    A dyninstAPI/src/parsing/DynParseCallback.C
    A dyninstAPI/src/parsing/DynParseCallback.h
    M dyninstAPI/src/parsing/Parsing.C
    M dyninstAPI/src/parsing/Parsing.h

  Log Message:
  -----------
  Extract DynParseCallback

This also inlines codeBytesUpdateCB.


  Commit: 731e35483bc0da9d2a055bc70d233ee8417b1060
      https://github.com/dyninst/dyninst/commit/731e35483bc0da9d2a055bc70d233ee8417b1060
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/BPatch/BPatch_addressSpace.C
    M dyninstAPI/src/BPatch/BPatch_edge.C
    M dyninstAPI/src/hybridCallbacks.C
    M dyninstAPI/src/image.h
    M dyninstAPI/src/mapped_object.C
    M dyninstAPI/src/mapped_object.h
    M dyninstAPI/src/parsing/CMakeLists.txt
    M dyninstAPI/src/parsing/DynCFGFactory.C
    M dyninstAPI/src/parsing/Parsing-arch.C
    R dyninstAPI/src/parsing/Parsing.C
    R dyninstAPI/src/parsing/Parsing.h
    M dyninstAPI/src/parsing/parse_func.C
    M dyninstAPI/src/parsing/parse_func.h
    M dyninstAPI/src/patching/function.C

  Log Message:
  -----------
  Remove Parsing.{h,C}

They aren't needed anymore.


  Commit: 691c5efe84f41577e50805f834f8d14205e12588
      https://github.com/dyninst/dyninst/commit/691c5efe84f41577e50805f834f8d14205e12588
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M dyninstAPI/src/parsing/CMakeLists.txt
    M dyninstAPI/src/parsing/DynParseCallback.C
    M dyninstAPI/src/parsing/DynParseCallback.h
    R dyninstAPI/src/parsing/Parsing-arch.C
    M dyninstAPI/src/parsing/parse_func.h

  Log Message:
  -----------
  Extract DynParseCallback::instruction_cb

There's no need to have a compile guard for it.


Compare: https://github.com/dyninst/dyninst/compare/fb6b56be53b5%5E...691c5efe84f4

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications