[DynInst_API:] [dyninst/dyninst] 639475: modernize ArchSpecificFormatter classes (#1464)

[kupsch <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 6394752592546df5adff6bc7edb2d8bde330842d
      https://github.com/dyninst/dyninst/commit/6394752592546df5adff6bc7edb2d8bde330842d
  Author: kupsch <kupsch@xxxxxxxxxxx>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M instructionAPI/h/ArchSpecificFormatters.h
    M instructionAPI/src/ArchSpecificFormatters.C

  Log Message:
  -----------
  modernize ArchSpecificFormatter classes (#1464)

- pass string and vector parameters by const reference instead of by
  value for performance

- add ArchSpecificFormatter::getInstructionString and remove the overridden
  versions in the non-x86_64 as they were functionally the same, but not
  identically written

- remove virtual and add override to overridden methods

- make methods const, use map::at instead of map::operator[]