[DynInst_API:] [dyninst/dyninst] db6c36: AddressTranslateSysV::adjustForAddrSpaceWrap: Fix ...


Date: Tue, 09 May 2023 09:06:55 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] db6c36: AddressTranslateSysV::adjustForAddrSpaceWrap: Fix ...
  Branch: refs/heads/fix_fd_leak_AddressTranslateSysV_adjustForAddrSpaceWrap
  Home:   https://github.com/dyninst/dyninst
  Commit: db6c365d3a2e86076d4b24e5eef1776324faac9f
      https://github.com/dyninst/dyninst/commit/db6c365d3a2e86076d4b24e5eef1776324faac9f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M common/src/addrtranslate-sysv.C

  Log Message:
  -----------
  AddressTranslateSysV::adjustForAddrSpaceWrap: Fix C file descriptor leak

Found using cppcheck:

common/src/addrtranslate-sysv.C:1046:58: error: Resource leak: fd [resourceLeak]
   if (read(fd, &e_hdr, sizeof(e_hdr)) != sizeof(e_hdr)) return base;
                                                         ^
common/src/addrtranslate-sysv.C:1048:28: error: Resource leak: fd [resourceLeak]
   if (e_hdr.e_phoff == 0) return base;


[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] db6c36: AddressTranslateSysV::adjustForAddrSpaceWrap: Fix ..., Tim Haines <=