[DynInst_API:] [dyninst/dyninst] 1d6bea: Make CondVar non-copyable, non-moveable


Date: Tue, 09 May 2023 07:55:01 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 1d6bea: Make CondVar non-copyable, non-moveable
  Branch: refs/heads/condvar_no_copy
  Home:   https://github.com/dyninst/dyninst
  Commit: 1d6bea6a30751f5978934280f5f5bb0dc12844c0
      https://github.com/dyninst/dyninst/commit/1d6bea6a30751f5978934280f5f5bb0dc12844c0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M common/src/dthread.h

  Log Message:
  -----------
  Make CondVar non-copyable, non-moveable

This makes it consistent with std::condition_variable.

Found using cppcheck:

common/src/dthread.h:114:4: warning: Class 'CondVar' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
   mutex = new mutex_t;
   ^
common/src/dthread.h:114:4: warning: Class 'CondVar' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
   mutex = new mutex_t;


[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 1d6bea: Make CondVar non-copyable, non-moveable, Tim Haines <=