[DynInst_API:] [dyninst/dyninst] 0d9b8e: Improve compiler diagnostic suppression handling (...

[kupsch <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 0d9b8e4c5ba6dfa5d5666956aca4404d49f2160a
      https://github.com/dyninst/dyninst/commit/0d9b8e4c5ba6dfa5d5666956aca4404d49f2160a
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    A common/h/compiler_diagnostics.h
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI_RT/h/dyninstAPI_RT.h
    M instructionAPI/src/Register.C

  Log Message:
  -----------
  Improve compiler diagnostic suppression handling (#1239)

- Create compiler specific diagnostic suppression macros to suppress a
  type of warning for a region of code that are consistently defined
  based on the build environment.
- Replace current multi-line preprocessor #if and #pragma statements
  with one macro.
- Add suppression for warnings in instructionAPI/src/Register.C
  when using gcc 6-8.


  Commit: c004b33915051bd1eed99edc81b49956dc8a1f8c
      https://github.com/dyninst/dyninst/commit/c004b33915051bd1eed99edc81b49956dc8a1f8c
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    M cmake/warnings.cmake
    M common/h/Annotatable.h
    M common/h/Graph.h
    M common/h/Node.h
    M common/h/util.h
    M common/src/arch-x86.h
    M common/src/debug_common.C
    M common/src/ntHeaders.h
    M dataflowAPI/src/debug_dataflow.C
    M dyninstAPI/h/BPatch.h
    M dyninstAPI/h/BPatch_dll.h
    M dyninstAPI/h/BPatch_function.h
    M dyninstAPI/h/BPatch_image.h
    M dyninstAPI/h/BPatch_point.h
    M instructionAPI/h/BinaryFunction.h
    M instructionAPI/h/InstructionAST.h
    M instructionAPI/h/InstructionDecoder.h
    M parseAPI/src/debug_parse.C
    M proccontrol/src/handler.C
    M proccontrol/src/irpc.C
    M proccontrol/src/process.C
    M proccontrol/src/processplat.C
    M proccontrol/src/procset.C
    M proccontrol/src/windows_process.h
    M proccontrol/src/x86_process.C
    M symtabAPI/src/debug.C

  Log Message:
  -----------
  Remove MSC compiler warning suppressions (#1239)

Likely no longer needed with current MSC compiler and will hide
problems if MSC is used.

- Removed diagnostic suppressing pragmas
- Removed compiler command line suppression options


  Commit: 59f82f2ba4c3ba2c2416e461fc45b1e8b5f48b58
      https://github.com/dyninst/dyninst/commit/59f82f2ba4c3ba2c2416e461fc45b1e8b5f48b58
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    M cmake/warnings.cmake
    M instructionAPI/CMakeLists.txt

  Log Message:
  -----------
  Fix frame-larger-than warning (#1239)

- Increase frame size max when using gcc 6 for non-debug builds and
  for all debug builds (needed for rhel's gcc) to compile
  instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.C


  Commit: d333a836c48a02afb31de58b9068f1f844a88244
      https://github.com/dyninst/dyninst/commit/d333a836c48a02afb31de58b9068f1f844a88244
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    M CMakeLists.txt
    M cmake/warnings.cmake

  Log Message:
  -----------
  Add cmake option to disable diagnostic suppressions (#1239)

- DYNINST_DISABLE_DIAGNOSTIC_SUPPRESSIONS option:  if set,
  disable all warning suppressions and frame size limit overrides


  Commit: 2a16fb4a46579e5b83a4289e7ecea0559400b70e
      https://github.com/dyninst/dyninst/commit/2a16fb4a46579e5b83a4289e7ecea0559400b70e
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    M CMakeLists.txt
    M cmake/warnings.cmake

  Log Message:
  -----------
  Add compiler warning related cmake options (#1239)

- DYNINST_WARNINGS_AS_ERRORS option:  if set, treat warnings as errors
- DYNINST_EXTRA_WARNINGS option:  additional warning options to test for
  and use if valid with the current compiler


Compare: https://github.com/dyninst/dyninst/compare/74320b0184de...2a16fb4a4657