[DynInst_API:] [dyninst/dyninst] d80989: Improve compiler diagnostic suppression handling (...

[kupsch <noreply@xxxxxxxxxx>]

  Branch: refs/heads/kupsch/fix-compiler-diagnostics
  Home:   https://github.com/dyninst/dyninst
  Commit: d8098917b5a14ecadb750c4dacf78838da8026ce
      https://github.com/dyninst/dyninst/commit/d8098917b5a14ecadb750c4dacf78838da8026ce
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    A common/h/compiler_diagnostics.h
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI_RT/h/dyninstAPI_RT.h
    M instructionAPI/src/Register.C

  Log Message:
  -----------
  Improve compiler diagnostic suppression handling (#1239)

- Create compiler specific diagnostic suppression macros to suppress a
  type of warning for a region of code that are consistently defined
  based on the build environment.
- Replace current multi-line preprocessor #if and #pragma statements
  with one macro.
- Add suppression for warnings in instructionAPI/src/Register.C
  when using gcc 6-8.


  Commit: 538109e8665a2d904d559281c24b12461714c4c7
      https://github.com/dyninst/dyninst/commit/538109e8665a2d904d559281c24b12461714c4c7
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M cmake/warnings.cmake
    M common/h/Annotatable.h
    M common/h/Graph.h
    M common/h/Node.h
    M common/h/util.h
    M common/src/arch-x86.h
    M common/src/debug_common.C
    M common/src/ntHeaders.h
    M dataflowAPI/src/debug_dataflow.C
    M dyninstAPI/h/BPatch.h
    M dyninstAPI/h/BPatch_dll.h
    M dyninstAPI/h/BPatch_function.h
    M dyninstAPI/h/BPatch_image.h
    M dyninstAPI/h/BPatch_point.h
    M instructionAPI/h/BinaryFunction.h
    M instructionAPI/h/InstructionAST.h
    M instructionAPI/h/InstructionDecoder.h
    M parseAPI/src/debug_parse.C
    M proccontrol/src/handler.C
    M proccontrol/src/irpc.C
    M proccontrol/src/process.C
    M proccontrol/src/processplat.C
    M proccontrol/src/procset.C
    M proccontrol/src/windows_process.h
    M proccontrol/src/x86_process.C
    M symtabAPI/src/debug.C

  Log Message:
  -----------
  Remove MSC compiler warning suppressions (#1239)

Likely no longer needed with current MSC compiler and will hide
problems if MSC is used.

- Removed diagnostic suppressing pragmas
- Removed compiler command line suppression options


  Commit: 84725241f482deaf2b707d7b0bcc9bdd654a8d7b
      https://github.com/dyninst/dyninst/commit/84725241f482deaf2b707d7b0bcc9bdd654a8d7b
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M cmake/warnings.cmake
    M instructionAPI/CMakeLists.txt

  Log Message:
  -----------
  Fix frame-larger-than warning (#1239)

- Increase frame size max when using gcc 6 for non-debug builds and
  for all debug builds (needed for rhel's gcc) to compile
  instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.C


  Commit: 510ce79a7e5eb41caa74638e59f1f0dd79347f99
      https://github.com/dyninst/dyninst/commit/510ce79a7e5eb41caa74638e59f1f0dd79347f99
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M CMakeLists.txt
    M cmake/warnings.cmake

  Log Message:
  -----------
  Add cmake option to disable diagnostic suppressions (#1239)

- DYNINST_DISABLE_DIAGNOSTIC_SUPPRESSIONS option:  if set,
  disable all warning suppressions and frame size limit overrides


  Commit: aff9d05a2cfb4537f5f7fd601ea41ba7f8aa0c82
      https://github.com/dyninst/dyninst/commit/aff9d05a2cfb4537f5f7fd601ea41ba7f8aa0c82
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M CMakeLists.txt
    M cmake/warnings.cmake

  Log Message:
  -----------
  Add compiler warning related cmake options (#1239)

- DYNINST_WARNINGS_AS_ERRORS option:  if set, treat warnings as errors
- DYNINST_EXTRA_WARNINGS option:  additional warning options to test for
  and use if valid with the current compiler


Compare: https://github.com/dyninst/dyninst/compare/fca602a0b9b4...aff9d05a2cfb