Re: [DynInst_API:] [RFC PATCH] Cleanup warnings

[Peter Foley <pefoley2@xxxxxxxxxxx>]

On Fri, Apr 29, 2016 at 5:24 PM, Bill Williams <bill@xxxxxxxxxxx> wrote:
> InstructionDecoder-aarch64.C: we'd better be null-checking and failing the
> entire decode if we hit the failure cases in this patch.

Since most of the functions that call this code path return void, it
wasn't at all clear what the right place to raise an error was.
Might it make more sense to add an "invalid" value to the Result_Type
enum and raise an error at whatever the correct higher level function
is?
Any pointers on the right place to check the Result_type value would
be appreciated.

Thanks,

Peter