Re: [DynInst_API:] [PATCH 1/2] Reduce namespace pollution


Date: Tue, 26 Apr 2016 10:03:51 -0700
From: Josh Stone <jistone@xxxxxxxxxx>
Subject: Re: [DynInst_API:] [PATCH 1/2] Reduce namespace pollution
On 04/25/2016 10:58 AM, Bill Williams wrote:
> I think what we want to maintain, at least for 9.x, is the following 
> guidelines:
> 
> * No "using namespace" in public headers (foo/h/*.h); "using foo::bar" 
> may be used but prefer typedefs if you want to clean up overly long 
> namespace chains
> * Any of "using namespace foo", "using foo::bar", and "foo::bar" is 
> acceptable in private headers and source files (foo/src/*.[hC]). "using 
> foo::bar" or explicit "foo::bar" at point of use is preferred in the 
> absence of typedefs; typedefs and auto are the preferred options we 
> should trend towards in new code.
> * If you're already touching a type, you may replace it with the most 
> preferred form (typedefs and auto to hide implementation details).
> * If you see something unacceptable, fix it.
> 
> This sound good to folks?

Works for me.
[← Prev in Thread] Current Thread [Next in Thread→]