Re: [DynInst_API:] Removed createInstPointAtAddr

[Josh Stone <jistone@xxxxxxxxxx>]

On 04/28/2012 11:51 AM, Andrew Bernat wrote:
> On Apr 28, 2012, at 11:42 AM, Josh Stone wrote:
>> As I asked before, would a 5-byte NOP for the SDT case help here?
>> Then you could possibly insert a jump without moving the rest of
>> the function around, which is why indirect jumps are generally
>> avoided, right?
> 
> In theory, yes, but... we'd have to rewrite the entire
> instrumentation system. We replace a block or function at a time. Is
> it really critical?

No it's not critical.  I'm mostly happy just understanding the reason
for limitation.  I just wanted to see if there was an easy fix from our
end, but an entire rewrite is not exactly low-hanging fruit.

>> Well createPointsAtAddr + insertSnippet appears to succeed -- what 
>> indication of failure should I see?  (Besides just not running...)
> 
> A lack of actually putting code in. Or possibly I forgot to check the
> instrumentable flag, and we try to do it anyway... not sure,
> actually.

OK, let's figure that out at least, rather than silently not working.


Josh