Re: [Condor-users] rooster on linux

[Dan Bradley <dan@xxxxxxxxxxxx>]

On 11/21/11 2:53 PM, Lukas Slebodnik wrote:
> On Mon, Nov 21, 2011 at 02:27:24PM -0600, Dan Bradley wrote:
> > > 11/21/11 14:07:03 UdpWakeOnLanWaker::doWake: Malformed subnet
> > > '255.255.255.128k144.92.167.252'
> > What does the classad for slot1@xxxxxxxxxxxxxxxxxxx look like?  Does
> > it contain the strange looking subnet string mentioned in the above
> > error message?
> >
> > --Dan
> Subnet mask is ok, but in constructor UdpWakeOnLanWaker::UdpWakeOnLanWaker
> SubnetMask attribute is wrong copied.
>
>     found = ad->LookupString (
>          ATTR_SUBNET_MASK,
>          m_subnet,
>          MAX_IP_ADDRESS_LENGTH-1 );
>
> where MAX_IP_ADDRESS_LENGTH is equal 16. So only 15 characters are copied
> "255.255.255.128" without tailing zero '\0' character.
>
> Regards,
> Lukas

Yikes.  Good catch!

I'm not familiar with that code.  In addition to patching this for 
7.6.5, we better review that area in 7.7 to make sure it jives with the 
new IPv6 support that's being added.

Thanks,
--Dan