[Condor-users] The UWCS_PERIODIC_CHECKPOINT default definition; OK?

[Rob <spamrefuse@xxxxxxxxx>]

Hi,

I'm worried about these lines in the default condor_config file:

PERIODIC_CHECKPOINT = $(UWCS_PERIODIC_CHECKPOINT)

UWCS_PERIODIC_CHECKPOINT = $(LastCkpt) > (3 * $(HOUR) + \
                                  $RANDOM_INTEGER(-30,30,1) * $(MINUTE) )

And hence:

$ condor_config_val PERIODIC_CHECKPOINT
PERIODIC_CHECKPOINT: (CurrentTime - LastPeriodicCheckpoint) > (3 * (60 * 60) + -23 * 60 )


Since the value of the RANDOM_INTEGER can be negative (between -30 and 30);
shouldn't this random number expression then be wrapped in an extra pair of brackets?
So instead of 

    (3 * (60 * 60) + -23 * 60 )

It should become:

    (3 * (60 * 60) + (-23) * 60 )

To prevent the "+" and "-" clash......

And therefore:

UWCS_PERIODIC_CHECKPOINT = $(LastCkpt) > (3 * $(HOUR) + \
                                  ($RANDOM_INTEGER(-30,30,1)) * $(MINUTE) )

Rob.