I don't see the benefit of delaying the warning. That just folks handle this issue when they upgrade to 7.7.6 instead of 7.8.5 (and I'd rather it pop up during a *devel* series than a *stable* series).
The config knob is a great idea, although I'd suggest doing:
ENABLE_DEPRECATION_WARNINGS
and we could reuse it in the future with deprecated configuration variables.
Brian On Apr 27, 2012, at 3:39 PM, John (TJ) Knoeller wrote:
I think Igor has a good point here. We should wait until 7.9 to
begin warning users by default
about use of Disk and Memory in requirements.
I think this is a good suggestion.
see https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=2835I propose that we do this. In particular I propose
- Create a new config knob
ENABLE_SUBMIT_WARNINGS_ABOUT_UPCOMING_POLICY set the default
value for this knob to FALSE.
- Have 7.8 check this knob before warning about Memory &
Disk in requirements
- Have 7.9 NOT check this knob before warning about Memory &
Disk.
- At about 7.8.5 either switch the default value for this knob
to TRUE, or remove the code that checks the knob for Memory
& Disk in requirements.
Also we should support Igor's use case of having a way to disable
Requirements checks against memory & disk entirely -
- Add code in condor_submit to check for a
request_memory=undefined
statement in the submit file, and have it NOT add a reference to
RequestMemory into Requirements in
that case.
-tj
On 4/26/2012 5:55 PM, Todd Tannenbaum wrote:
On
4/25/2012 5:27 PM, Igor Sfiligoi wrote:
Here is one gotcha:
[1523] sfiligoi@cabinet-10-10-2 ~/submit/one$ condor_submit
a.condor
Submitting job(s)
WARNING: Your Requirements _expression_ refers to TARGET.Disk.
This is
obsolete. Set request_disk and condor_submit will modify the
Requirements _expression_ as needed.
WARNING: your Requirements _expression_ refers to TARGET.Memory.
This is
obsolete. Set request_memory and condor_submit will modify the
Requirements _expression_ as needed.
.
1 job(s) submitted to cluster 1.
And
[1525] sfiligoi@cabinet-10-10-2 ~/submit/one$ condor_q -l |grep
-i req
RequestDisk = DiskUsage
Requirements = ( ( Arch =!= "abc" ) ) && ( ( Memory
>= 1 ) && ( Disk >=
1 ) ) && ( TARGET.OpSys == "LINUX" ) && (
TARGET.Disk >= RequestDisk )
&& ( TARGET.Memory >= RequestMemory ) && ( (
TARGET.HasFileTransfer ) ||
( TARGET.FileSystemDomain == MY.FileSystemDomain ) )
RequestMemory = ifthenelse(MemoryUsage =!=
undefined,MemoryUsage,1)
RequestCpus = 1
We have been setting
APPEND_REQ_VANILLA = (Memory>=1)&&(Disk>=1)
for a long time to get around the annoying tendency of Condor of
auto-appending them in the job requirements.
Essentially every glideinWMS installation out there has it!
Hmmm, you could (should?) now set in your condor_config:
JOB_DEFAULT_REQUESTMEMORY = 1
JOB_DEFAULT_REQUESTDISK = 1
to achieve the same thing you were doing with the
APPEND_REQ_VANILLA
While only a warning, it may screw up many scripts who may
interpret it
as a real problem.
These warning go out to stderr (not stdout), and do not impact
exit code of condor_status. Do you still think we need a knob to
silence them?
regards,
Todd
Igor
PS: The testing continues.
On 04/25/2012 09:47 AM, Todd Tannenbaum wrote:
Hi Igor -
Could we pretty pretty please have you (or someone in
glideinWMS) run
the "Igor regression test" in the next couple days?
<bribe>I'll buy you dinner next week in
return!</bribe>
thanks
Todd
-------- Original Message --------
Subject: [Condor-users] Condor 7.7.6 released!
Date: Wed, 25 Apr 2012 10:26:33 -0500
From: Greg Thain <gthain@xxxxxxxxxxx>
Reply-To: Condor-Users Mail List
<condor-users@xxxxxxxxxxx>
To: Condor-Users Mail List <condor-users@xxxxxxxxxxx>
The Condor team is pleased to announce the newest release in
our
development series, 7.7.6. This release represents the release
candidate
for Condor version 7.8, and it is the last release in the 7.7
development series. Please see the release notes for a
complete list at
http://research.cs.wisc.edu/condor/manual/v7.7/9_3Development_Release.html
Condor binaries and source code are available from our
downloads page at
http://www.cs.wisc.edu/condor/downloads/
Thank you for your interest in Condor!
_______________________________________________
Condor-users mailing list
To unsubscribe, send a message to
condor-users-request@xxxxxxxxxxx with a
subject: Unsubscribe
You can also unsubscribe by visiting
https://lists.cs.wisc.edu/mailman/listinfo/condor-users
The archives can be found at:
https://lists.cs.wisc.edu/archive/condor-users/
Condor-devel mailing list
Condor-devel@xxxxxxxxxxx
https://lists.cs.wisc.edu/mailman/listinfo/condor-devel |
