Re: [Condor-devel] Why do DaemonCore timers return int?

[Matthew Farrellee <matt@xxxxxxxxxx>]

Alan De Smet wrote:
> Is there a good reason for DaemonCore timers to return an int?
> The code that calls them (TimerManager::Timeout,
> timer_manager.cpp, around line 362) ignores it.  If it's
> useless, it seems it should return void to eliminate potential
> confusion.
> 

>From what I can tell Todd might know why it's that way, git blame traces back to him.

To make matters more amusing, if you look at the Schedd or Startd you'll notice that many of the timers actually return void and are cast to TimerHandlercpp, which returns int.

Apparently some timers are already confused. In the Negotiator, some timers return TRUE when they "succeed" and FALSE otherwise.

I'd support int -> void.

Best,


matt