Re: [Condor-devel] Errno locations

[Tristan Halvorson <tristan@xxxxxxxxxxx>]

Oops, I forgot the attachment :(

Tristan

Tristan Halvorson wrote:
> It's been suggested that I send out my earlier work on finding places 
> where errno is used incorrectly to condor-devel.  The line numbers are 
> probably stale by now, but I've included the function, too, so 
> hopefully they're easy enough to find.
> If anyone knows otherwise on any of these, feel free to let me know.  
> I went with the assumption that if msdn.microsoft.com didn't document 
> errno for the function, we couldn't rely on the behavior.
>
> Tristan

The problem is usually on Windows.  If it's not specifically labelled then it's either broken on Windows or everywhere, it should be easy to tell, or if all else fails look at a man page.
Errno is used incorrectly in the following locations:

classad_log.C				602,166			fflush()
cbstp_url.C					38				socket()
cbstp_url.C					51				connect()
condor_config.C				1884			rotate_file()
cronjob.C					876, 896		Create_Pipe()
file_lock.C					245				lock_file()
PipeBuffer.C				116				Write_Pipe()
ftp_url.C					91				socket()
ftp_url.C					131				connect()
get_full_hostname.C			86				gethostbyname()
http_url.C					74				socket()
http_url.C					120				connect()
log_transaction.C			76				fflush()
my_hostname.C				187				get_full_hostname()
user_log.C					479				fflush()
daemon.C					1581			gethostbyaddr()
dc_credd.C					*				code(), cod_bytes()
daemon_core.C				2397 + more		fwrite()
daemon_core.C				5608			setsid()
condor_dagman/submit.C		168				my_pclose()
condor_dagman/util.C		60				my_pclose()
gahp_client.C				666				Create_Pipe()
DownloadReplicaTransferer.C	75				connect()
ReplicatorStateMachine.C	723, 768		Send_Signal()
reli_sock.C					677				GetLastError() (WSA?)
SafeMsg.C					705, 739, 760	sendto()
safe_sock.C					565				recvfrom()
qmgmt_receivers.C			*				NewCluster(), NewProc()
	- all of this file and qmgmt_send_stubs.C, errnos aren't the same on different platforms
NTReceivers.C				617				setMipiMasterInfo()
NTReceivers.C				782				pseudo_get_job_attr()
NTReceivers.C				809				pseudo_set_job_attr()
NTReceivers.C				832				pseudo_contain()
schedd.V6/pseudo_ops.C		439				code_bytes()
schedd.V6/pseudo_ops.C		1431			tcp_accept_timeout()
user_proc.C					319				get_file()
io_proxy.C					*				lots, not win32 safe
stream_handler.C			63				Create_Pipe()
idle_time.C					943				kstat_open() (Solaris only)
stork/dap_server.C			1344			malloc()
stork/dap_server.C			1428			code() (3 occurrences)
stork/dap_server.C			1612			code() (4 occurrences)
stork/dap_server.C			1915			code()
stork/dap_server.C			2326			code()
stork/dap_server.C			2335			eom()
stork/dap_server.C			2348			code() (2 occurrences)