Re: [Condor-devel] [Condor-status] Pete's Week

[Peter Keller <psilord@xxxxxxxxxxx>]

On Fri, Aug 31, 2007 at 09:59:09AM -0500, Erik Paulson wrote:
> On Thu, Aug 30, 2007 at 10:20:46PM -0500, Peter Keller wrote:
> > Hello,
> > 
> > + Checked in enough fixes to the macosx port on the 6.8 branch so VDT
> > can use it as a submission point.
> > 
> 
> 1. Why did you include my_popen.h? You don't use it in your patch.

I had a different solution which used ps to get some of the missing
information, but it needed a caching solution due to performance. When
6.9.4 blew up, I ripped out this more intelligent code because I didn't
have enough time to get it right by the deadline.

> 2. Remember, if the user condor is in the right group, or if the kernel
> setting has been changed, task_for_pid is available to non-root users. 
> You've hard-coded it so it will never work for non-root users, though.
> 
>         if (is_root()) {                                                        
>           // figure out the image,rss size and the sys/usr time for the process.
> 			task_for_pid();
> 		else {
> 			//make up numbers
> 		}
> 
> That should be something like
> 
> 	bool use_task_for_pid = param_bool("USE_TASK_FOR_PID", false)
> 	if(is_root() || use_task_for_pid) {
> 	}
> 
> That way, people can configure their mac so non-root Condors can still get all
> of the information.

That's a good idea. Do you want to add the couple lines of code and the
additional knob to the manual?

-pete