Branch: refs/heads/bbiiggppiigg/amdgpu-idfa-regression-test
Home: https://github.com/dyninst/dyninst
Commit: 0c1436e936a6096d9d3244b332c39da620d03559
https://github.com/dyninst/dyninst/commit/0c1436e936a6096d9d3244b332c39da620d03559
Author: wuxx1279 <bbiiggppiigg@xxxxxxxxx>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M tests/regression/parseAPI/IndirectControlFlowAnalysis/branchInfo.cpp
Log Message:
-----------
Clean up branchInfo.cpp per review
Address code-review feedback on the AMDGPU IndirectControlFlowAnalysis
test driver:
- Remove the unused forward declarations; declare/initialize symTab, sts,
and co (with auto) at their point of use.
- Rename the function-list variable from `all` to `funcs` to reflect that
it is a container.
- Remove the unused `bb_addrs` set and the loop that populated it.
- Use range-based for loops over functions and blocks.
- Declare the decoded `instr` with auto at its point of use.
- Remove the unused `operands` variable and the now-unused <set> include.
- Return -1 when the output file cannot be opened, instead of falling
through and exiting with success.
No behavior change on the happy path: output for the 908/90a/940 gpubins
still matches the expected references.
Co-Authored-By: Claude Opus 4.8 <noreply@xxxxxxxxxxxxx>
To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
|