[DynInst_API:] [dyninst/dyninst] 5d1d31: Clean up, refactor codeGen class (#2245)

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 5d1d31b7f78551f2967e098ae74ff7a458657e07
      https://github.com/dyninst/dyninst/commit/5d1d31b7f78551f2967e098ae74ff7a458657e07
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-10 (Sun, 10 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Clean up, refactor codeGen class (#2245)

* Remove verify()

Its not currently used. The actual verification calculation was removed
by 799ef6c8b in 2011.

* Remove unused codeBuf_t* ctor

* Remove unused copy assignment operator

The compiler won't generate one since there is a user-defined dtor.

* Make it move-only

The only place a copy was being made was in
SpringboardBuilder::generateSpringboard, but it was just copying a
local into a container so a move was better.

* Remove unused equality operators

* Remove baseTemplate

Its usage was removed by 0a3392d0e in 2009.

* Remove unused finalize()

* Remove copyAligned

Its usage was removed some time around 2010.

* Remove unused copy(codeGen&)

* Remove unused size()

* Remove unused max()

* Make get_ptr private

It's only used in the class

* Inline currAddr(Dyninst::Address)

* Remove unused fillRemaining(int)

* Remove PCRels functions

Their definitions were removed by a86833d92 in 2025.

* Remove ddPatch(const relocPatch &)

* Remove applyPatches()

* Remove defensive pad functions

Their usage was removed by 8bb4aa76a in 2011.

* Remove get/registerInstrumentation

Their usage was removed by 8bb4aa76a in 2011.

* Remove get/registerRemovedInstrumentation

Their usage was removed by 7ce20933e4 in 2011.

* Remove isPadded_

* Use in-class initializers

* Inline codeGen(int) ctor

* Clean up includes in source file

* Zero buffer_ on allocation



To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications