[DynInst_API:] [dyninst/dyninst] ae0b51: Remove verify()

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/cleanup_codeGen
  Home:   https://github.com/dyninst/dyninst
  Commit: ae0b51e274f40711e9d01f469862012c7454fb7d
      https://github.com/dyninst/dyninst/commit/ae0b51e274f40711e9d01f469862012c7454fb7d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove verify()

Its not currently used. The actual verification calculation was removed
by 799ef6c8b in 2011.


  Commit: ed2455753bdccc76b2c80c0dead7fb3d03abce10
      https://github.com/dyninst/dyninst/commit/ed2455753bdccc76b2c80c0dead7fb3d03abce10
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused codeBuf_t* ctor


  Commit: f5cbba6828382cb95879972cdcb694116d2d0bda
      https://github.com/dyninst/dyninst/commit/f5cbba6828382cb95879972cdcb694116d2d0bda
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy assignment operator

The compiler won't generate one since there is a user-defined dtor.


  Commit: 6e37dc8c8fdd915cbd388be31dabe6e2fbd5b7b5
      https://github.com/dyninst/dyninst/commit/6e37dc8c8fdd915cbd388be31dabe6e2fbd5b7b5
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make it move-only

The only place a copy was being made was in
SpringboardBuilder::generateSpringboard, but it was just copying a
local into a container so a move was better.


  Commit: cd35acddc2d5223227b6833566d3a77dc8a4400c
      https://github.com/dyninst/dyninst/commit/cd35acddc2d5223227b6833566d3a77dc8a4400c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused equality operators


  Commit: d29d33e4bc22f30bc765c18887f7e7b1d2afd6ea
      https://github.com/dyninst/dyninst/commit/d29d33e4bc22f30bc765c18887f7e7b1d2afd6ea
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove baseTemplate

Its usage was removed by 0a3392d0e in 2009.


  Commit: 3b1e1a3d129c3978acf26aefa523f4ea57ec1d70
      https://github.com/dyninst/dyninst/commit/3b1e1a3d129c3978acf26aefa523f4ea57ec1d70
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused finalize()


  Commit: fc2bd432916ae108825b142614604ebf48c34700
      https://github.com/dyninst/dyninst/commit/fc2bd432916ae108825b142614604ebf48c34700
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove copyAligned

Its usage was removed some time around 2010.


  Commit: b15e7e1ad5ccc0fe74df70999979de1e0eb67fd9
      https://github.com/dyninst/dyninst/commit/b15e7e1ad5ccc0fe74df70999979de1e0eb67fd9
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy(codeGen&)


  Commit: a0367a63cb66af04dfaace1b78d05080cfde0d77
      https://github.com/dyninst/dyninst/commit/a0367a63cb66af04dfaace1b78d05080cfde0d77
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused size()


  Commit: bf42b7d74c61495f61300d2fbb455c99cbddb9bf
      https://github.com/dyninst/dyninst/commit/bf42b7d74c61495f61300d2fbb455c99cbddb9bf
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused max()


  Commit: 549a32c92e947ecfb82e97db873c1c46705f993f
      https://github.com/dyninst/dyninst/commit/549a32c92e947ecfb82e97db873c1c46705f993f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make get_ptr private

It's only used in the class


  Commit: da5300562654ac3f1a12b39012b9aae43c51c7d4
      https://github.com/dyninst/dyninst/commit/da5300562654ac3f1a12b39012b9aae43c51c7d4
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline currAddr(Dyninst::Address)


  Commit: 712b18100a382a8040744b9a6b20c44ffdaaefc2
      https://github.com/dyninst/dyninst/commit/712b18100a382a8040744b9a6b20c44ffdaaefc2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused fillRemaining(int)


  Commit: 41ced3ed1425bc7b38a14b8ad8047a8e37014299
      https://github.com/dyninst/dyninst/commit/41ced3ed1425bc7b38a14b8ad8047a8e37014299
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove PCRels functions

Their definitions were removed by a86833d92 in 2025.


  Commit: 2e030d9dae650194139f1ec4c5dded40522ce287
      https://github.com/dyninst/dyninst/commit/2e030d9dae650194139f1ec4c5dded40522ce287
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove ddPatch(const relocPatch &)


  Commit: 706e710175bf2f4f0fe8a60856bcf1f79ab68490
      https://github.com/dyninst/dyninst/commit/706e710175bf2f4f0fe8a60856bcf1f79ab68490
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove applyPatches()


  Commit: 0ed6d3c24b37b1445ab49da0a889980329899b1c
      https://github.com/dyninst/dyninst/commit/0ed6d3c24b37b1445ab49da0a889980329899b1c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove defensive pad functions

Their usage was removed by 8bb4aa76a in 2011.


  Commit: 1c3f608da1aaf958fe607ca9e3db2e51c8361782
      https://github.com/dyninst/dyninst/commit/1c3f608da1aaf958fe607ca9e3db2e51c8361782
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerInstrumentation

Their usage was removed by 8bb4aa76a in 2011.


  Commit: 5c66768347551dad5bc2e4d48ec5c41cb7666dba
      https://github.com/dyninst/dyninst/commit/5c66768347551dad5bc2e4d48ec5c41cb7666dba
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerRemovedInstrumentation

Their usage was removed by 7ce20933e4 in 2011.


  Commit: b2815b910824ed28a1207b654150cd75e433e2ed
      https://github.com/dyninst/dyninst/commit/b2815b910824ed28a1207b654150cd75e433e2ed
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove isPadded_


  Commit: 4a817b830a96e4e0886efe916a539738b78601a2
      https://github.com/dyninst/dyninst/commit/4a817b830a96e4e0886efe916a539738b78601a2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Use in-class initializers


  Commit: 1f7f4b9892089636777524d2bb29d514b17a890a
      https://github.com/dyninst/dyninst/commit/1f7f4b9892089636777524d2bb29d514b17a890a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline codeGen(int) ctor


  Commit: 1c37f2871402aab37a377c9ad8731a3de98a5da1
      https://github.com/dyninst/dyninst/commit/1c37f2871402aab37a377c9ad8731a3de98a5da1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Clean up includes in source file


  Commit: 256f392ab3b9c66817b66933373296f25e926c8f
      https://github.com/dyninst/dyninst/commit/256f392ab3b9c66817b66933373296f25e926c8f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Zero buffer_ on allocation


Compare: https://github.com/dyninst/dyninst/compare/3091ac4d5728...256f392ab3b9

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications