[DynInst_API:] [dyninst/dyninst] ee8a53: Remove verify()


Date: Thu, 07 May 2026 15:26:27 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] ee8a53: Remove verify()
  Branch: refs/heads/thaines/cleanup_codeGen
  Home:   https://github.com/dyninst/dyninst
  Commit: ee8a53e0444ff1e7b0c87bbb324fddec723a94b9
      https://github.com/dyninst/dyninst/commit/ee8a53e0444ff1e7b0c87bbb324fddec723a94b9
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove verify()

Its not currently used. The actual verification calculation was removed
by 799ef6c8b in 2011.


  Commit: a1d61dd926a65cb999b1fca3352817bd13581eab
      https://github.com/dyninst/dyninst/commit/a1d61dd926a65cb999b1fca3352817bd13581eab
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused codeBuf_t* ctor


  Commit: cae7aab0658956a95b9979bdcd86e536bda7b5e7
      https://github.com/dyninst/dyninst/commit/cae7aab0658956a95b9979bdcd86e536bda7b5e7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy assignment operator

The compiler won't generate one since there is a user-defined dtor.


  Commit: ab29e52156361950252926cca2bb52c8060ce31c
      https://github.com/dyninst/dyninst/commit/ab29e52156361950252926cca2bb52c8060ce31c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make it move-only

The only place a copy was being made was in
SpringboardBuilder::generateSpringboard, but it was just copying a
local into a container so a move was better.


  Commit: 302132ddc69638060da26227876a4f5ba068a1ef
      https://github.com/dyninst/dyninst/commit/302132ddc69638060da26227876a4f5ba068a1ef
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused equality operators


  Commit: 982e34cdf308d53278fc2edf3ac51f0b056d8eda
      https://github.com/dyninst/dyninst/commit/982e34cdf308d53278fc2edf3ac51f0b056d8eda
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove baseTemplate

Its usage was removed by 0a3392d0e in 2009.


  Commit: 85f1494d929d2275bb4791da8f560a70498b1507
      https://github.com/dyninst/dyninst/commit/85f1494d929d2275bb4791da8f560a70498b1507
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused finalize()


  Commit: b7eced635aa4b9efabf25c6bb5b9caa4231677a5
      https://github.com/dyninst/dyninst/commit/b7eced635aa4b9efabf25c6bb5b9caa4231677a5
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove copyAligned

Its usage was removed some time around 2010.


  Commit: 41b3f1a669268ca65980c95d718b1842d533fb05
      https://github.com/dyninst/dyninst/commit/41b3f1a669268ca65980c95d718b1842d533fb05
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy(codeGen&)


  Commit: cb2a1b96d14490b913c0b1a43a7af23c63b0fa74
      https://github.com/dyninst/dyninst/commit/cb2a1b96d14490b913c0b1a43a7af23c63b0fa74
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused size()


  Commit: a7927cd91e2b720e5bb1d8dd509ba07d760449f7
      https://github.com/dyninst/dyninst/commit/a7927cd91e2b720e5bb1d8dd509ba07d760449f7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused max()


  Commit: 7373ccd23ff59a475bc89f1fa0d7cc7c8c948fc9
      https://github.com/dyninst/dyninst/commit/7373ccd23ff59a475bc89f1fa0d7cc7c8c948fc9
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make get_ptr private

It's only used in the class


  Commit: 6be398db5d10b109a31da8338d5eb2ed9f3cc229
      https://github.com/dyninst/dyninst/commit/6be398db5d10b109a31da8338d5eb2ed9f3cc229
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline currAddr(Dyninst::Address)


  Commit: 443b8969f61571a0bbc122c89b0127de7dbcda38
      https://github.com/dyninst/dyninst/commit/443b8969f61571a0bbc122c89b0127de7dbcda38
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused fillRemaining(int)


  Commit: ab8d32573cecab74336d8cb2e8f7ee2c998b3508
      https://github.com/dyninst/dyninst/commit/ab8d32573cecab74336d8cb2e8f7ee2c998b3508
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove PCRels functions

Their definitions were removed by a86833d92 in 2025.


  Commit: adfd1f42af20ed8480bfd480c34383ad017638e1
      https://github.com/dyninst/dyninst/commit/adfd1f42af20ed8480bfd480c34383ad017638e1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove ddPatch(const relocPatch &)


  Commit: ce5c3d78fadfa3b9576d7ffc6b6ad444fd7d14f7
      https://github.com/dyninst/dyninst/commit/ce5c3d78fadfa3b9576d7ffc6b6ad444fd7d14f7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove applyPatches()


  Commit: 5e0c51202c4bcfe2ed9c42a601bc193ee9b19418
      https://github.com/dyninst/dyninst/commit/5e0c51202c4bcfe2ed9c42a601bc193ee9b19418
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove defensive pad functions

Their usage was removed by 8bb4aa76a in 2011.


  Commit: 1dcc6388fbe56c521c3c3af528cbc3856c4b6679
      https://github.com/dyninst/dyninst/commit/1dcc6388fbe56c521c3c3af528cbc3856c4b6679
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerInstrumentation

Their usage was removed by 8bb4aa76a in 2011.


  Commit: bce9e661d486b5183616f92ebbdb1ab1fc425ecf
      https://github.com/dyninst/dyninst/commit/bce9e661d486b5183616f92ebbdb1ab1fc425ecf
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerRemovedInstrumentation

Their usage was removed by 7ce20933e4 in 2011.


  Commit: 24acd135b55bcd90c8cd499406a01e5d5365a966
      https://github.com/dyninst/dyninst/commit/24acd135b55bcd90c8cd499406a01e5d5365a966
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove isPadded_


  Commit: 39c5f197586f19db4b4965b56dacb0716fc2dc55
      https://github.com/dyninst/dyninst/commit/39c5f197586f19db4b4965b56dacb0716fc2dc55
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Use in-class initializers


  Commit: 41134e38b4ce93ef1950dc86aeee248d5b670ae7
      https://github.com/dyninst/dyninst/commit/41134e38b4ce93ef1950dc86aeee248d5b670ae7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline codeGen(int) ctor


  Commit: 82fe3569cc1e478b7754a5d352bbf873e4a27786
      https://github.com/dyninst/dyninst/commit/82fe3569cc1e478b7754a5d352bbf873e4a27786
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Clean up includes in source file


  Commit: 3091ac4d5728e26652e860d461c79890cf8afd19
      https://github.com/dyninst/dyninst/commit/3091ac4d5728e26652e860d461c79890cf8afd19
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-07 (Thu, 07 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Zero buffer_ on allocation


Compare: https://github.com/dyninst/dyninst/compare/bec00762966d...3091ac4d5728

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] ee8a53: Remove verify(), Tim Haines <=