[DynInst_API:] [dyninst/dyninst] 49b7ab: Remove verify()


Date: Wed, 06 May 2026 19:50:07 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 49b7ab: Remove verify()
  Branch: refs/heads/thaines/cleanup_codeGen
  Home:   https://github.com/dyninst/dyninst
  Commit: 49b7abfc80ac02aa3bf072d9c3dcdc0c15239e42
      https://github.com/dyninst/dyninst/commit/49b7abfc80ac02aa3bf072d9c3dcdc0c15239e42
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove verify()

Its not currently used. The actual verification calculation was removed
by 799ef6c8b in 2011.


  Commit: 6f1f292342d040f768fd68a9f827c03ffb89c2a5
      https://github.com/dyninst/dyninst/commit/6f1f292342d040f768fd68a9f827c03ffb89c2a5
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused codeBuf_t* ctor


  Commit: 38df5dd1274b4ebf27f0bdb52c495b64cbedfb00
      https://github.com/dyninst/dyninst/commit/38df5dd1274b4ebf27f0bdb52c495b64cbedfb00
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy assignment operator

The compiler won't generate one since there is a user-defined dtor.


  Commit: 117966f48ce83c43f445f0419cfaf9026d4c1fa8
      https://github.com/dyninst/dyninst/commit/117966f48ce83c43f445f0419cfaf9026d4c1fa8
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make it move-only

The only place a copy was being made was in
SpringboardBuilder::generateSpringboard, but it was just copying a
local into a container so a move was better.


  Commit: 0585b4b530b8d40a601b0210b359b11e92d500ac
      https://github.com/dyninst/dyninst/commit/0585b4b530b8d40a601b0210b359b11e92d500ac
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused equality operators


  Commit: 8f4527eb4485fb4a807c7c487a31654c18367507
      https://github.com/dyninst/dyninst/commit/8f4527eb4485fb4a807c7c487a31654c18367507
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove baseTemplate

Its usage was removed by 0a3392d0e in 2009.


  Commit: 3899e535eb73e60c8c38358dd246dab3af69b9fd
      https://github.com/dyninst/dyninst/commit/3899e535eb73e60c8c38358dd246dab3af69b9fd
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused finalize()


  Commit: e117832a0e80923c7340b0f6bf52529d8e5e2b30
      https://github.com/dyninst/dyninst/commit/e117832a0e80923c7340b0f6bf52529d8e5e2b30
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove copyAligned

Its usage was removed some time around 2010.


  Commit: 93b25e9841a59d091a9515ca8901522cacd88b28
      https://github.com/dyninst/dyninst/commit/93b25e9841a59d091a9515ca8901522cacd88b28
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy(codeGen&)


  Commit: db36d695e5aa3183ff6be0390adc9f0f376805ca
      https://github.com/dyninst/dyninst/commit/db36d695e5aa3183ff6be0390adc9f0f376805ca
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused size()


  Commit: d93d0aa48c8ac64329491382ae92c1a9976487da
      https://github.com/dyninst/dyninst/commit/d93d0aa48c8ac64329491382ae92c1a9976487da
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused max()


  Commit: a0b27423259455e33eb1daaeb6347f5a4ffaf9bb
      https://github.com/dyninst/dyninst/commit/a0b27423259455e33eb1daaeb6347f5a4ffaf9bb
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make get_ptr private

It's only used in the class


  Commit: 595406c050b7cefd073c61cd07cf4e63106105ab
      https://github.com/dyninst/dyninst/commit/595406c050b7cefd073c61cd07cf4e63106105ab
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline currAddr(Dyninst::Address)


  Commit: 9324ea6834b97032059e789eab319a23e588f078
      https://github.com/dyninst/dyninst/commit/9324ea6834b97032059e789eab319a23e588f078
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused fillRemaining(int)


  Commit: 7fd2e682ed921126628b70e23d6435892b92bb0d
      https://github.com/dyninst/dyninst/commit/7fd2e682ed921126628b70e23d6435892b92bb0d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove PCRels functions

Their definitions were removed by a86833d92 in 2025.


  Commit: 071d35c46fcecaf2c56ded8d1c2aef6c432c4b2f
      https://github.com/dyninst/dyninst/commit/071d35c46fcecaf2c56ded8d1c2aef6c432c4b2f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove ddPatch(const relocPatch &)


  Commit: 0b04676ed73a4f573ec3f5135d36e3528828af18
      https://github.com/dyninst/dyninst/commit/0b04676ed73a4f573ec3f5135d36e3528828af18
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove applyPatches()


  Commit: c2df99ac83805702c9a8fec31ae3583035c3cc89
      https://github.com/dyninst/dyninst/commit/c2df99ac83805702c9a8fec31ae3583035c3cc89
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove defensive pad functions

Their usage was removed by 8bb4aa76a in 2011.


  Commit: 8739e8302807cd495e292ed9944d1132f7dfdcfa
      https://github.com/dyninst/dyninst/commit/8739e8302807cd495e292ed9944d1132f7dfdcfa
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerInstrumentation

Their usage was removed by 8bb4aa76a in 2011.


  Commit: da91384938ba4095ee5b6bb9f0392f19e3912794
      https://github.com/dyninst/dyninst/commit/da91384938ba4095ee5b6bb9f0392f19e3912794
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerRemovedInstrumentation

Their usage was removed by 7ce20933e4 in 2011.


  Commit: d59a27b035051544bafbf15ee70be51c5a6640cf
      https://github.com/dyninst/dyninst/commit/d59a27b035051544bafbf15ee70be51c5a6640cf
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove isPadded_


  Commit: 46712959b64a88c9ce58fed24f17af26b8ff6183
      https://github.com/dyninst/dyninst/commit/46712959b64a88c9ce58fed24f17af26b8ff6183
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Use in-class initializers


  Commit: c0aa38bcbb1ab717b7c74089d123392b284b0862
      https://github.com/dyninst/dyninst/commit/c0aa38bcbb1ab717b7c74089d123392b284b0862
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline codeGen(int) ctor


  Commit: 73d0deb0c8cd28946af18dc2241cc4ce4b5750f7
      https://github.com/dyninst/dyninst/commit/73d0deb0c8cd28946af18dc2241cc4ce4b5750f7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Clean up includes in source file


  Commit: b32bc59bbc20d0b75614c97124d8a66010329052
      https://github.com/dyninst/dyninst/commit/b32bc59bbc20d0b75614c97124d8a66010329052
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Zero buffer_ on allocation


Compare: https://github.com/dyninst/dyninst/compare/dabe80494264...b32bc59bbc20

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 49b7ab: Remove verify(), Tim Haines <=