[DynInst_API:] [dyninst/dyninst] 253ff6: Remove verify()


Date: Wed, 06 May 2026 10:53:46 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 253ff6: Remove verify()
  Branch: refs/heads/thaines/cleanup_codeGen
  Home:   https://github.com/dyninst/dyninst
  Commit: 253ff67cc2f3669975d04266f77c9d1ee3eea022
      https://github.com/dyninst/dyninst/commit/253ff67cc2f3669975d04266f77c9d1ee3eea022
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove verify()

Its not currently used. The actual verification calculation was removed
by 799ef6c8b in 2011.


  Commit: 8b2692620e387b2d2dd35ee4668b6ada99b7237e
      https://github.com/dyninst/dyninst/commit/8b2692620e387b2d2dd35ee4668b6ada99b7237e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused codeBuf_t* ctor


  Commit: 6fa50170b1ae3c934260b7448366b03fd217a060
      https://github.com/dyninst/dyninst/commit/6fa50170b1ae3c934260b7448366b03fd217a060
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy assignment operator

The compiler won't generate one since there is a user-defined dtor.


  Commit: 41e32c404b72a4d297cbdeafbe3819138b210dfd
      https://github.com/dyninst/dyninst/commit/41e32c404b72a4d297cbdeafbe3819138b210dfd
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make it move-only

The only place a copy was being made was in
SpringboardBuilder::generateSpringboard, but it was just copying a
local into a container so a move was better.


  Commit: a484fcfcd6e59327d87a70644ca5ff3d000e0e49
      https://github.com/dyninst/dyninst/commit/a484fcfcd6e59327d87a70644ca5ff3d000e0e49
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused equality operators


  Commit: e27eaddb9029c4a8d4965fbcae54a193e5171c8d
      https://github.com/dyninst/dyninst/commit/e27eaddb9029c4a8d4965fbcae54a193e5171c8d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove baseTemplate

Its usage was removed by 0a3392d0e in 2009.


  Commit: ac29f478dbb5df6e9bf7a942822a105d2e733109
      https://github.com/dyninst/dyninst/commit/ac29f478dbb5df6e9bf7a942822a105d2e733109
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused finalize()


  Commit: 1d9d9512d80fc2a6ec06eebe6def45a61a81833a
      https://github.com/dyninst/dyninst/commit/1d9d9512d80fc2a6ec06eebe6def45a61a81833a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove copyAligned

Its usage was removed some time around 2010.


  Commit: 296e4a2982501a25caff71ddfddc8e12a9e87a11
      https://github.com/dyninst/dyninst/commit/296e4a2982501a25caff71ddfddc8e12a9e87a11
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused copy(codeGen&)


  Commit: 3538bfb2fa6a08cbe77111172c979a15b62d9dfa
      https://github.com/dyninst/dyninst/commit/3538bfb2fa6a08cbe77111172c979a15b62d9dfa
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused size()


  Commit: a35d03633e8d71ca2b3b6a8d143a610636aa870d
      https://github.com/dyninst/dyninst/commit/a35d03633e8d71ca2b3b6a8d143a610636aa870d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused max()


  Commit: be3df10b7ba4fd661fcb558df4e227512d997e85
      https://github.com/dyninst/dyninst/commit/be3df10b7ba4fd661fcb558df4e227512d997e85
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Make get_ptr private

It's only used in the class


  Commit: 3ae285b84c35db544516998c2a834885556c531a
      https://github.com/dyninst/dyninst/commit/3ae285b84c35db544516998c2a834885556c531a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline currAddr(Dyninst::Address)


  Commit: b83307a979a5ef9cc2822259e2aaa95885b1b03a
      https://github.com/dyninst/dyninst/commit/b83307a979a5ef9cc2822259e2aaa95885b1b03a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove unused fillRemaining(int)


  Commit: d43b5b26f00e25b5f6d465f629550181bc1bb123
      https://github.com/dyninst/dyninst/commit/d43b5b26f00e25b5f6d465f629550181bc1bb123
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove PCRels functions

Their definitions were removed by a86833d92 in 2025.


  Commit: a8972b5b38cc70b6bbb360658da2858ba770a901
      https://github.com/dyninst/dyninst/commit/a8972b5b38cc70b6bbb360658da2858ba770a901
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove ddPatch(const relocPatch &)


  Commit: b1e1eb8a0bd729b7c93f856ff92de1ed665c58bc
      https://github.com/dyninst/dyninst/commit/b1e1eb8a0bd729b7c93f856ff92de1ed665c58bc
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove applyPatches()


  Commit: 929a91f93bdd0eac8e23a39c2d7da20c44ecd42b
      https://github.com/dyninst/dyninst/commit/929a91f93bdd0eac8e23a39c2d7da20c44ecd42b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove defensive pad functions

Their usage was removed by 8bb4aa76a in 2011.


  Commit: 1749765601415adf6d5276923dc04a13a2d6f0c2
      https://github.com/dyninst/dyninst/commit/1749765601415adf6d5276923dc04a13a2d6f0c2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerInstrumentation

Their usage was removed by 8bb4aa76a in 2011.


  Commit: f627c9c47c9b73acad99db97ee6b8753f193f524
      https://github.com/dyninst/dyninst/commit/f627c9c47c9b73acad99db97ee6b8753f193f524
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove get/registerRemovedInstrumentation

Their usage was removed by 7ce20933e4 in 2011.


  Commit: 5490ab5c72fb79a627ab8653c7d6106e9d45e2f6
      https://github.com/dyninst/dyninst/commit/5490ab5c72fb79a627ab8653c7d6106e9d45e2f6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Remove isPadded_


  Commit: f495b313040dbb3812f189483e5c3f80645fd85f
      https://github.com/dyninst/dyninst/commit/f495b313040dbb3812f189483e5c3f80645fd85f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Use in-class initializers


  Commit: 611879ba9c490fde8b80b1b52b4f53169d273dc2
      https://github.com/dyninst/dyninst/commit/611879ba9c490fde8b80b1b52b4f53169d273dc2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h

  Log Message:
  -----------
  Inline codeGen(int) ctor


  Commit: dabe8049426442231a7b9e0c270314577f2ac61a
      https://github.com/dyninst/dyninst/commit/dabe8049426442231a7b9e0c270314577f2ac61a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M dyninstAPI/src/codegen.C

  Log Message:
  -----------
  Clean up includes in source file


Compare: https://github.com/dyninst/dyninst/compare/253ff67cc2f3%5E...dabe80494264

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 253ff6: Remove verify(), Tim Haines <=