[DynInst_API:] [dyninst/dyninst] 379869: Extract instMapping

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/cleanup_instMapping
  Home:   https://github.com/dyninst/dyninst
  Commit: 379869755e71ee8d6f8c1880dc3f502886523c76
      https://github.com/dyninst/dyninst/commit/379869755e71ee8d6f8c1880dc3f502886523c76
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/src/BPatch_addressSpace.C
    M dyninstAPI/src/BPatch_point.C
    M dyninstAPI/src/BPatch_private.h
    M dyninstAPI/src/Relocation/DynInstrumenter.C
    M dyninstAPI/src/Relocation/DynInstrumenter.h
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/dynProcess.h
    M dyninstAPI/src/inst.C
    M dyninstAPI/src/inst.h
    A dyninstAPI/src/instMapping.C
    A dyninstAPI/src/instMapping.h
    M dyninstAPI/src/syscallNotification.C
    M dyninstAPI/src/syscallNotification.h

  Log Message:
  -----------
  Extract instMapping


  Commit: ef32eb2575aa09fe4e9dccc10d9e596fdd1723e5
      https://github.com/dyninst/dyninst/commit/ef32eb2575aa09fe4e9dccc10d9e596fdd1723e5
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Modernize loops


  Commit: b36c4267d76570e237ba1632a1ab407be5e4de67
      https://github.com/dyninst/dyninst/commit/b36c4267d76570e237ba1632a1ab407be5e4de67
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Don't typedef enums


  Commit: 41a282a59c8e7706a6eba29d1f01f73287ac26aa
      https://github.com/dyninst/dyninst/commit/41a282a59c8e7706a6eba29d1f01f73287ac26aa
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Don't use explicit pointer checks


  Commit: cad89093d556090b71ccf2e00aae3a6cdb8f4c67
      https://github.com/dyninst/dyninst/commit/cad89093d556090b71ccf2e00aae3a6cdb8f4c67
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove dtor

The compiler-provided one is sufficient and now allows compiler to
generate move and copy operations.


  Commit: 4feb0d40e3fa46e9f69cb761a9390ffb071bbb89
      https://github.com/dyninst/dyninst/commit/4feb0d40e3fa46e9f69cb761a9390ffb071bbb89
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove extraneous access specifier


  Commit: 143dac188574a2cdc4dd482cb8da8b84c4533c71
      https://github.com/dyninst/dyninst/commit/143dac188574a2cdc4dd482cb8da8b84c4533c71
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Reduce string copies


  Commit: 7e9e5d6e859a7e1d2acf3a9993b034e79a8debff
      https://github.com/dyninst/dyninst/commit/7e9e5d6e859a7e1d2acf3a9993b034e79a8debff
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove explicit namespace prefix


  Commit: 377af1c00aca093e49b5c3560e6dbc2c293adc3b
      https://github.com/dyninst/dyninst/commit/377af1c00aca093e49b5c3560e6dbc2c293adc3b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Make is_MTonly const


  Commit: b87433480d7061c738cea205ff232d56ea508b6c
      https://github.com/dyninst/dyninst/commit/b87433480d7061c738cea205ff232d56ea508b6c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove unused ctors


  Commit: d709c79a07b6f9fab9b90ca6f2537be352fc6987
      https://github.com/dyninst/dyninst/commit/d709c79a07b6f9fab9b90ca6f2537be352fc6987
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/inst.h
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Extract instrumentation location macros


  Commit: 8a2655b5ea7ab701e02a3d9d6a203420c2ca636f
      https://github.com/dyninst/dyninst/commit/8a2655b5ea7ab701e02a3d9d6a203420c2ca636f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove unused markAs_MTonly


  Commit: 2c081748d3832bc9f77e8303cf284701c050325c
      https://github.com/dyninst/dyninst/commit/2c081748d3832bc9f77e8303cf284701c050325c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Use in-class initializers for members not set in ctor


  Commit: 8543e477af4b03251a02cc6a3ad6ca15171c98b0
      https://github.com/dyninst/dyninst/commit/8543e477af4b03251a02cc6a3ad6ca15171c98b0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/instMapping.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove mt_only

It's always 'false', so just remove the check.


  Commit: f65bbb442a3051f99838c434ba2f7a23a46feadd
      https://github.com/dyninst/dyninst/commit/f65bbb442a3051f99838c434ba2f7a23a46feadd
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove library name

It's always empty.


  Commit: 46a7981a0e48c6c9253d4c15c9cfb0c139ee2855
      https://github.com/dyninst/dyninst/commit/46a7981a0e48c6c9253d4c15c9cfb0c139ee2855
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/instMapping.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove 'when'

It's never used.


  Commit: d502c7866f1be60fd07d6744c8a85c8ea8311cd6
      https://github.com/dyninst/dyninst/commit/d502c7866f1be60fd07d6744c8a85c8ea8311cd6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/instMapping.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Remove 'order'

It's always set to orderLastAtPoint, so the check in PCProcess::installInstrRequests
is always false.


  Commit: 06e9324a53ef6440ac0b170012e7c12dc820a413
      https://github.com/dyninst/dyninst/commit/06e9324a53ef6440ac0b170012e7c12dc820a413
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    R dyninstAPI/src/instMapping.C
    M dyninstAPI/src/instMapping.h

  Log Message:
  -----------
  Inline "fork" ctor


  Commit: eddc5e864571b32f5558545a7b666705639e28d0
      https://github.com/dyninst/dyninst/commit/eddc5e864571b32f5558545a7b666705639e28d0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-04-21 (Tue, 21 Apr 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    R dyninstAPI/src/inst.C

  Log Message:
  -----------
  Remove inst.C

It's no longer needed.


Compare: https://github.com/dyninst/dyninst/compare/379869755e71%5E...eddc5e864571

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications