[DynInst_API:] [dyninst/dyninst] bd02c9: Convert appendOperand to add_operand


Date: Mon, 30 Mar 2026 13:48:24 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] bd02c9: Convert appendOperand to add_operand
  Branch: refs/heads/thaines/operand_decoding_riscv
  Home:   https://github.com/dyninst/dyninst
  Commit: bd02c95089dbb4bbe90a744b9d6e936bb1cf677c
      https://github.com/dyninst/dyninst/commit/bd02c95089dbb4bbe90a744b9d6e936bb1cf677c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-30 (Mon, 30 Mar 2026)

  Changed paths:
    M instructionAPI/src/InstructionDecoderImpl.h
    M instructionAPI/src/decoder/riscv/decoder.C

  Log Message:
  -----------
  Convert appendOperand to add_operand


  Commit: 3a5a1424fe25eb8aff78e59cd25fdab3596adee3
      https://github.com/dyninst/dyninst/commit/3a5a1424fe25eb8aff78e59cd25fdab3596adee3
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-30 (Mon, 30 Mar 2026)

  Changed paths:
    M instructionAPI/src/InstructionDecoderImpl.h
    M instructionAPI/src/decoder/riscv/decoder.C

  Log Message:
  -----------
  Convert appendOperand to add_cft_target

In add_branch_insn_successors, the CFT operand for riscv64_op_jal and
riscv64_op_jalr are now explicitly marked as implicit. Without this, the
decoder tests were failing due to the extra explicit operand. It's
unclear why this change is needed since the previous call to
addSuccessor implicitly set 'isImplicit' to false.


  Commit: 1d37e1da8d8f2b4d5e013018418f8313074510d4
      https://github.com/dyninst/dyninst/commit/1d37e1da8d8f2b4d5e013018418f8313074510d4
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-30 (Mon, 30 Mar 2026)

  Changed paths:
    M instructionAPI/src/decoder/riscv/decoder.C
    M instructionAPI/src/decoder/riscv/decoder.h

  Log Message:
  -----------
  Convert appendEncodedOperand to add_encoded_operand


  Commit: e0216cd5f43db680dd2d6e83f92571cbe9a7cd59
      https://github.com/dyninst/dyninst/commit/e0216cd5f43db680dd2d6e83f92571cbe9a7cd59
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-30 (Mon, 30 Mar 2026)

  Changed paths:
    M instructionAPI/src/decoder/riscv/decoder.C
    M instructionAPI/src/decoder/riscv/decoder.h

  Log Message:
  -----------
  Remove unneeded Instruction parameters


  Commit: 3126f67e105e1170fcc45919670e5bd741e1d576
      https://github.com/dyninst/dyninst/commit/3126f67e105e1170fcc45919670e5bd741e1d576
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-30 (Mon, 30 Mar 2026)

  Changed paths:
    M instructionAPI/src/decoder/riscv/decoder.C
    M instructionAPI/src/decoder/riscv/decoder.h

  Log Message:
  -----------
  Make Instruction parameters 'const'


Compare: https://github.com/dyninst/dyninst/compare/bd02c95089db%5E...3126f67e105e

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] bd02c9: Convert appendOperand to add_operand, Tim Haines <=