[DynInst_API:] [dyninst/dyninst] 2d0c39: Move x86 operand sizes into arch-x86.C

Mailing List Archives Authenticated access	UW Madison Computer Sciences Department Computer Systems Lab
Date:	Wed, 25 Mar 2026 18:52:39 -0700
From:	Tim Haines <noreply@xxxxxxxxxx>
Subject:	[DynInst_API:] [dyninst/dyninst] 2d0c39: Move x86 operand sizes into arch-x86.C
  Branch: refs/heads/thaines/x86_arch_split
  Home:   https://github.com/dyninst/dyninst
  Commit: 2d0c39afd915a61a75c7f45726ba1a728be7d05b
      https://github.com/dyninst/dyninst/commit/2d0c39afd915a61a75c7f45726ba1a728be7d05b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Move x86 operand sizes into arch-x86.C

It's the only place they're used.


  Commit: 064ea559991c8083101391a1dc47c63354407e62
      https://github.com/dyninst/dyninst/commit/064ea559991c8083101391a1dc47c63354407e62
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove set_disp

Its usage was removed by dee8900ad in 2011.


  Commit: 8809fb7d9cf58a06dfaa94521fe2ecb318b2816e
      https://github.com/dyninst/dyninst/commit/8809fb7d9cf58a06dfaa94521fe2ecb318b2816e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Move declaration of displacement(const unsigned char*,unsigned)

It's only used in the source file.


  Commit: 4aef4295f43d6d0f6d9d79b4869dfbe4d9f2a5af
      https://github.com/dyninst/dyninst/commit/4aef4295f43d6d0f6d9d79b4869dfbe4d9f2a5af
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove is_disp16

It's not used.


  Commit: 604302005688018245258d0c01899a1abe4526df
      https://github.com/dyninst/dyninst/commit/604302005688018245258d0c01899a1abe4526df
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    M instructionAPI/src/InstructionDecoder-x86.C

  Log Message:
  -----------
  Move decode_SIB into x86 decoder

That's the only place it's used.


  Commit: a196e35b7c353abb573e8c84e144e3871217b996
      https://github.com/dyninst/dyninst/commit/a196e35b7c353abb573e8c84e144e3871217b996
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Move skip_headers into source file

It's only used there.


  Commit: b5b097b689def0465192fa00c8f255a303e2b7fc
      https://github.com/dyninst/dyninst/commit/b5b097b689def0465192fa00c8f255a303e2b7fc
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove insn_hasSIB

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 632086a6ffc3e1ee85bad247ccf354971ddd6b73
      https://github.com/dyninst/dyninst/commit/632086a6ffc3e1ee85bad247ccf354971ddd6b73
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove insn_hasDisp8

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 4658b766e53fc27fe46636cf2397ca3c07fd4e5a
      https://github.com/dyninst/dyninst/commit/4658b766e53fc27fe46636cf2397ca3c07fd4e5a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove insn_hasDisp32

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 95496bec89aab7400a7536526617ce01ca878d49
      https://github.com/dyninst/dyninst/commit/95496bec89aab7400a7536526617ce01ca878d49
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    M parseAPI/src/Parser-speculative.C

  Log Message:
  -----------
  Move isStackFramePrecheck_gcc/msvs into Parser-speculative.C

That's the only place they're used.


  Commit: 264d2e01eb557ef3cfc3eaafe53f3845f6d0e6e2
      https://github.com/dyninst/dyninst/commit/264d2e01eb557ef3cfc3eaafe53f3845f6d0e6e2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    A common/src/arch-regs-x86.h
    M common/src/arch-x86.h
    M dyninstAPI/src/ASTs/jumpTargetAST.C
    M dyninstAPI/src/ASTs/scrambleRegistersAST.C
    M dyninstAPI/src/ASTs/stackInsertionAST.C
    M dyninstAPI/src/ASTs/stackRemovalAST.C
    M dyninstAPI/src/RegisterConversion-x86.C
    M dyninstAPI/src/Relocation/Widgets/CFWidget-x86.C
    M dyninstAPI/src/codegen-x86.C
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/emit-x86.C
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI/src/registerSpace/registerSpace-x86.C
    M dyninstAPI/src/registerSpace/registerSpace.C
    M tests/unit/dyninstAPI/emitter/x86_64.cpp

  Log Message:
  -----------
  Extract architecture register numbers


  Commit: 66ba944be552a9db2fb1c5f9064121138490a431
      https://github.com/dyninst/dyninst/commit/66ba944be552a9db2fb1c5f9064121138490a431
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused ADD macros

They were added by 3040ff8f8 in 2005, but never used.


  Commit: 7a621c4209aa748df89d52afa081833d3a80c115
      https://github.com/dyninst/dyninst/commit/7a621c4209aa748df89d52afa081833d3a80c115
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused opcode macros


  Commit: c8aec08ed068833a01b2465549d65a0963a63586
      https://github.com/dyninst/dyninst/commit/c8aec08ed068833a01b2465549d65a0963a63586
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused size macros


  Commit: 297b9ee1bb68ca809574921a9f87f78636fac333
      https://github.com/dyninst/dyninst/commit/297b9ee1bb68ca809574921a9f87f78636fac333
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h
    M instructionAPI/src/InstructionDecoder-x86.C

  Log Message:
  -----------
  Move type aliases into decoder

It's the only place they're used.


  Commit: d5543ab28cab940618333886d60484d1bc097116
      https://github.com/dyninst/dyninst/commit/d5543ab28cab940618333886d60484d1bc097116
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  remove ia32_entry::flagsUsed

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 8eefebf1aa264e8dfef5c5c3dba83de913bc2131
      https://github.com/dyninst/dyninst/commit/8eefebf1aa264e8dfef5c5c3dba83de913bc2131
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    M instructionAPI/src/Operation.C

  Log Message:
  -----------
  Move flag semantics into Operation

It's the only placed they're used.


  Commit: 53b8d0edd14cf4459f370719d058360785900700
      https://github.com/dyninst/dyninst/commit/53b8d0edd14cf4459f370719d058360785900700
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused RepGroup


  Commit: 1c283f9fba065afb29ecdc0dc0aed3b7ab8fd3cc
      https://github.com/dyninst/dyninst/commit/1c283f9fba065afb29ecdc0dc0aed3b7ab8fd3cc
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Move implicit operand specifiers into source file


  Commit: df7cf1665f99ef82ea3b880450b18c4816ed495d
      https://github.com/dyninst/dyninst/commit/df7cf1665f99ef82ea3b880450b18c4816ed495d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused implicit mask macros


  Commit: b2db39582c4772f7672c59c857172de3295b6024
      https://github.com/dyninst/dyninst/commit/b2db39582c4772f7672c59c857172de3295b6024
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused instruction decorators


  Commit: 09f3bf2cf5e506442c9e063a51e5c901a411d7e8
      https://github.com/dyninst/dyninst/commit/09f3bf2cf5e506442c9e063a51e5c901a411d7e8
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused modR/M and SIB types


  Commit: eab48dbcf7cfcaea7c8f26ac97da9303e3ae0303
      https://github.com/dyninst/dyninst/commit/eab48dbcf7cfcaea7c8f26ac97da9303e3ae0303
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    A common/src/encoding-x86.h

  Log Message:
  -----------
  Extract encoding data


  Commit: 4e6931adaf6132597298117d21b94135a071b90c
      https://github.com/dyninst/dyninst/commit/4e6931adaf6132597298117d21b94135a071b90c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Move apply_rex_bit into source file


  Commit: d562a760b7556f7c9f87643707e80315db360e5f
      https://github.com/dyninst/dyninst/commit/d562a760b7556f7c9f87643707e80315db360e5f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove unused dynamic_call_address_mode


  Commit: 711a7fc094edbbae43592244cdae516901e59687
      https://github.com/dyninst/dyninst/commit/711a7fc094edbbae43592244cdae516901e59687
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h
    M common/src/encoding-x86.h

  Log Message:
  -----------
  Clean up EXTENDED opcode macros


  Commit: 66c984a04579010c4ed5f2c345fa763dd9163c6b
      https://github.com/dyninst/dyninst/commit/66c984a04579010c4ed5f2c345fa763dd9163c6b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    A common/src/ia32_memacc.C
    A common/src/ia32_memacc.h

  Log Message:
  -----------
  Extract ia32_memacc


  Commit: 0a7d7cc3b24cff1aedb39a5892fc5f33c6ceaa95
      https://github.com/dyninst/dyninst/commit/0a7d7cc3b24cff1aedb39a5892fc5f33c6ceaa95
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    M common/src/arch-x86.h
    A common/src/ia32_prefixes.C
    A common/src/ia32_prefixes.h

  Log Message:
  -----------
  Extract is32_prefixes


  Commit: 503f085aafd13a02a223fc3e02f5cc002945c6be
      https://github.com/dyninst/dyninst/commit/503f085aafd13a02a223fc3e02f5cc002945c6be
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    M common/h/entryIDs.h
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    M common/src/encoding-x86.h
    A common/src/ia32_entry.C
    A common/src/ia32_entry.h
    M parseAPI/src/ProbabilisticParser.C

  Log Message:
  -----------
  Extract is32_entry

The 'name' and 'getID' member functions weren't extracted because they are
too entwined with the decoder tables.


  Commit: 5339250896d66c0e180c210d4d5606f095aef908
      https://github.com/dyninst/dyninst/commit/5339250896d66c0e180c210d4d5606f095aef908
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h
    A common/src/ia32_instruction.h

  Log Message:
  -----------
  Extract ia32_instruction


  Commit: 31f62700f672b36cfe82e51a0da12abf592c01bf
      https://github.com/dyninst/dyninst/commit/31f62700f672b36cfe82e51a0da12abf592c01bf
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h
    M common/src/encoding-x86.h

  Log Message:
  -----------
  Extract more encodings


  Commit: 1432940867221e3304fbf07811cb44a4f61fb84d
      https://github.com/dyninst/dyninst/commit/1432940867221e3304fbf07811cb44a4f61fb84d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-25 (Wed, 25 Mar 2026)

  Changed paths:
    M common/CMakeLists.txt
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    A common/src/instruction-x86.C
    A common/src/instruction-x86.h
    M dyninstAPI/src/codegen-x86.C

  Log Message:
  -----------
  Extract instruction class


Compare: https://github.com/dyninst/dyninst/compare/2d0c39afd915%5E...143294086722

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread]	Current Thread	[Next in Thread→]
[DynInst_API:] [dyninst/dyninst] 2d0c39: Move x86 operand sizes into arch-x86.C, Tim Haines <=
Previous by Date:	[DynInst_API:] [dyninst/dyninst] ed26bf: Remove insnCodeGen::generateMem, Tim Haines
Next by Date:	[DynInst_API:] [dyninst/dyninst] ff3925: Add codegen arch guard for new files, Tim Haines
Previous by Thread:	[DynInst_API:] [dyninst/dyninst] 2cf8fc: Add Operation::operator==, Tim Haines
Next by Thread:	[DynInst_API:] [dyninst/dyninst] 2d88da: Split up the low-level x86 architecture classes (#..., Tim Haines
Indexes:	[Date] [Thread]
Mailing List Archives

Authenticated access

[DynInst_API:] [dyninst/dyninst] 2d0c39: Move x86 operand sizes into arch-x86.C
