[DynInst_API:] [dyninst/dyninst] 3f69a1: Remove dead code in architecture files (#2174)

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 3f69a18f46e4c088f81b9a0bb8ef76d056d8bb98
      https://github.com/dyninst/dyninst/commit/3f69a18f46e4c088f81b9a0bb8ef76d056d8bb98
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-aarch64.C
    M common/src/arch-aarch64.h
    M common/src/arch-amdgpu.C
    M common/src/arch-amdgpu.h
    M common/src/arch-power.C
    M common/src/arch-power.h
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    R common/src/arch.h
    M dyninstAPI/src/codegen-power.C
    M dyninstAPI/src/codegen-x86.C

  Log Message:
  -----------
  Remove dead code in architecture files (#2174)

* Remove dead code in insnCodeGen::generate on ppc

It was removed by e15b10217 in 2018.

* Remove swapBytesIfNeeded

It was removed by e15b10217 in 2018.

* Remove instruction::swapBytes

It's no longer needed.

* Remove NS_common::instruction

It's never used.

* Move (MAX,MIN)_IMM16 into arch-power

That's the only place it's used.

* Remove arch.h

It's no longer needed.

* Remove x86 READ/WRITE_OP

Their usage was removed by 388f9589b in 2007.

* Remove x86 JUMP_ABS64_SZ

Its usage was removed by 041bad2f6 in 2015.

* Remove x86 ptest from flag table

Its usage was removed by 8c410bddb in 2015.

* Remove x86 isStackFramePreamble

Its usage was removed by 62b7d1f21 in 2010.

* Remove duplicate SIB_SET_REG and SIB_SET_INDEX macros

Only the definition in codegen-x86.C is used.

* Remove x86 SIB_SET_SS

Its usage was removed by 556bc2b3a in 2017.

* Clean up ppc instructionUnion

The code was removed by 02bc600ea55 in 2010.

* Remove unneeded comment in ppc

* Remove isCallInsn, isReturnInsn in ppc

Their usage was removed by 6cdf9b049 in 2005.

* Remove unused masks in aarch64

Their usage was removed by b0ced1cb30c in 2015.



To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications