[DynInst_API:] [dyninst/dyninst] c256d8: Remove dead code in insnCodeGen::generate on ppc


Date: Tue, 24 Mar 2026 10:51:25 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] c256d8: Remove dead code in insnCodeGen::generate on ppc
  Branch: refs/heads/thaines/remove_arch_dead_code
  Home:   https://github.com/dyninst/dyninst
  Commit: c256d8df1c9c3cbb8f406e9fe15af549864ac0ad
      https://github.com/dyninst/dyninst/commit/c256d8df1c9c3cbb8f406e9fe15af549864ac0ad
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M dyninstAPI/src/codegen-power.C

  Log Message:
  -----------
  Remove dead code in insnCodeGen::generate on ppc

It was removed by e15b10217 in 2018.


  Commit: 85b31bfe25698862617888eeb85951ea3d1f5e70
      https://github.com/dyninst/dyninst/commit/85b31bfe25698862617888eeb85951ea3d1f5e70
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-aarch64.C
    M common/src/arch-aarch64.h
    M common/src/arch-amdgpu.C
    M common/src/arch-amdgpu.h
    M common/src/arch-power.C
    M common/src/arch-power.h
    M common/src/arch-x86.C
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove swapBytesIfNeeded

It was removed by e15b10217 in 2018.


  Commit: 94d1bf3b04ed02dc4acbcecb998c39c53fa153d6
      https://github.com/dyninst/dyninst/commit/94d1bf3b04ed02dc4acbcecb998c39c53fa153d6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-aarch64.C
    M common/src/arch-aarch64.h
    M common/src/arch-amdgpu.C
    M common/src/arch-amdgpu.h
    M common/src/arch-power.C
    M common/src/arch-power.h

  Log Message:
  -----------
  Remove instruction::swapBytes

It's no longer needed.


  Commit: f6fcd8d92dec575822e8a52592ec390b3a93c35c
      https://github.com/dyninst/dyninst/commit/f6fcd8d92dec575822e8a52592ec390b3a93c35c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch.h

  Log Message:
  -----------
  Remove NS_common::instruction

It's never used.


  Commit: fe91640f301c6a1051e7943318d68be5efacd070
      https://github.com/dyninst/dyninst/commit/fe91640f301c6a1051e7943318d68be5efacd070
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-power.h
    M common/src/arch.h

  Log Message:
  -----------
  Move (MAX,MIN)_IMM16 into arch-power

That's the only place it's used.


  Commit: cce9403cc38298a7946161340f2d2a49b7f9b272
      https://github.com/dyninst/dyninst/commit/cce9403cc38298a7946161340f2d2a49b7f9b272
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-aarch64.h
    M common/src/arch-power.h
    M common/src/arch-x86.h
    R common/src/arch.h

  Log Message:
  -----------
  Remove arch.h

It's no longer needed.


  Commit: c64af275a00e44e74dcaf5e8ba6e9baaf8a08d30
      https://github.com/dyninst/dyninst/commit/c64af275a00e44e74dcaf5e8ba6e9baaf8a08d30
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove x86 READ/WRITE_OP

Their usage was removed by 388f9589b in 2007.


  Commit: a54d412de9b4d546caec59bfcbbcf3a3679d56ef
      https://github.com/dyninst/dyninst/commit/a54d412de9b4d546caec59bfcbbcf3a3679d56ef
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.h

  Log Message:
  -----------
  Remove x86 JUMP_ABS64_SZ

Its usage was removed by 041bad2f6 in 2015.


  Commit: 81ff935cb154393e7c1342c20fb7fe239ee8b843
      https://github.com/dyninst/dyninst/commit/81ff935cb154393e7c1342c20fb7fe239ee8b843
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C

  Log Message:
  -----------
  Remove x86 ptest from flag table

Its usage was removed by 8c410bddb in 2015.


  Commit: 0472622d3f1c6684422fee8c3bb8e9558b4e50c2
      https://github.com/dyninst/dyninst/commit/0472622d3f1c6684422fee8c3bb8e9558b4e50c2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C

  Log Message:
  -----------
  Remove x86 isStackFramePreamble

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 871a155bc1a0be10fe7ef85fe390903d187dbb9d
      https://github.com/dyninst/dyninst/commit/871a155bc1a0be10fe7ef85fe390903d187dbb9d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C

  Log Message:
  -----------
  Remove duplicate SIB_SET_REG and SIB_SET_INDEX macros

Only the definition in codegen-x86.C is used.


  Commit: 3ecf89c42c060f7aecd7613b69ffb854d1f1005e
      https://github.com/dyninst/dyninst/commit/3ecf89c42c060f7aecd7613b69ffb854d1f1005e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-x86.C
    M dyninstAPI/src/codegen-x86.C

  Log Message:
  -----------
  Remove x86 SIB_SET_SS

Its usage was removed by 556bc2b3a in 2017.


  Commit: ffd45fbfb2f5246ff1df3457330d71e69d23a9ae
      https://github.com/dyninst/dyninst/commit/ffd45fbfb2f5246ff1df3457330d71e69d23a9ae
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-power.h

  Log Message:
  -----------
  Clean up ppc instructionUnion

The code was removed by 02bc600ea55 in 2010.


  Commit: 89a61a6a30ade7412959261b2fd4ba56629ca6ea
      https://github.com/dyninst/dyninst/commit/89a61a6a30ade7412959261b2fd4ba56629ca6ea
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-power.h

  Log Message:
  -----------
  Remove unneeded comment in ppc


  Commit: a9c6cfbc279b9053ef708638111bfbd84abeabf6
      https://github.com/dyninst/dyninst/commit/a9c6cfbc279b9053ef708638111bfbd84abeabf6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-power.h

  Log Message:
  -----------
  Remove isCallInsn, isReturnInsn in ppc

Their usage was removed by 6cdf9b049 in 2005.


  Commit: 806cc18f485d05a3087f727d80e34e22ef410f30
      https://github.com/dyninst/dyninst/commit/806cc18f485d05a3087f727d80e34e22ef410f30
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M common/src/arch-aarch64.h

  Log Message:
  -----------
  Remove unused masks in aarch64

Their usage was removed by b0ced1cb30c in 2015.


Compare: https://github.com/dyninst/dyninst/compare/c256d8df1c9c%5E...806cc18f485d

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] c256d8: Remove dead code in insnCodeGen::generate on ppc, Tim Haines <=