[DynInst_API:] [dyninst/dyninst] 608e91: Correctly handle IP/PC for x86_64


Date: Sat, 01 Feb 2025 23:08:48 -0800
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 608e91: Correctly handle IP/PC for x86_64
  Branch: refs/heads/thaines/rose_reg_x86
  Home:   https://github.com/dyninst/dyninst
  Commit: 608e9171e4c376e1bdd70f78841a5cb915ac0926
      https://github.com/dyninst/dyninst/commit/608e9171e4c376e1bdd70f78841a5cb915ac0926
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/convert.C
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Correctly handle IP/PC for x86_64


  Commit: cd605157bc46ae41ce4a1868d0255b79a64cd012
      https://github.com/dyninst/dyninst/commit/cd605157bc46ae41ce4a1868d0255b79a64cd012
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Fix position flag for x86::X87


  Commit: 661a8f7869fcad400b816829e226b924df06f420
      https://github.com/dyninst/dyninst/commit/661a8f7869fcad400b816829e226b924df06f420
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h

  Log Message:
  -----------
  Fix x86::x87 major version

The st_top is just for the top of the stack.


  Commit: 59fc6184469224fe7fc34162576aeebccd3f2ee8
      https://github.com/dyninst/dyninst/commit/59fc6184469224fe7fc34162576aeebccd3f2ee8
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Fix x86_64::x87 major version

The st_top is just for the top of the stack.


  Commit: 4f1dd182197c27bffd79f923c8a55fae535df7b0
      https://github.com/dyninst/dyninst/commit/4f1dd182197c27bffd79f923c8a55fae535df7b0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h

  Log Message:
  -----------
  Handle x86 kmask registers


  Commit: e451f9d61ac0c59b68e9ddd014279f454925c2bd
      https://github.com/dyninst/dyninst/commit/e451f9d61ac0c59b68e9ddd014279f454925c2bd
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h

  Log Message:
  -----------
  Use correct position flags for x86 vector registers

There is a non-obvious comment in the ROSE registers that the qword flag
is only meant for GPRs.


  Commit: c093c764fb42eaf8319e6bcb08208d296c3b1270
      https://github.com/dyninst/dyninst/commit/c093c764fb42eaf8319e6bcb08208d296c3b1270
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Use correct position flags for x86_64 vector registers

There is a non-obvious comment in the ROSE registers that the qword flag
is only meant for GPRs.


  Commit: cb6348c1a0d438b86cd24c2d361bbe2159e7db2e
      https://github.com/dyninst/dyninst/commit/cb6348c1a0d438b86cd24c2d361bbe2159e7db2e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h

  Log Message:
  -----------
  Use correct position flag for x86 segment registers

This was hidden in the ROSE register comments.


  Commit: b790660f1c514adbf674ed9bee7ba950d4987eed
      https://github.com/dyninst/dyninst/commit/b790660f1c514adbf674ed9bee7ba950d4987eed
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Fix position flag for x86_64 segment registers

This was hidden in the ROSE register comments.


  Commit: c03e0f305df5c77b81312205f1502d0f310746f0
      https://github.com/dyninst/dyninst/commit/c03e0f305df5c77b81312205f1502d0f310746f0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/convert.C

  Log Message:
  -----------
  Use x86_regpos_qword for rflags


  Commit: 20d8b27288c7c2632e9d9f98649db55b2fa570a3
      https://github.com/dyninst/dyninst/commit/20d8b27288c7c2632e9d9f98649db55b2fa570a3
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h
    M dataflowAPI/rose/registers/x86_64.h
    M dataflowAPI/src/ExpressionConversionVisitor.C

  Log Message:
  -----------
  Use x86_regpos_dword for x86/x86_64 segment register

x86_regpos_all was being treated as a synonym, but this makes it clear
what the actual size is.


  Commit: 241ec6b9fadab76df3f43fd1252376259a174e60
      https://github.com/dyninst/dyninst/commit/241ec6b9fadab76df3f43fd1252376259a174e60
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Use x86_regpos_qword for x86_64 64-bit registers


  Commit: ed5d37e721600566a1bd277529d4c298f638f712
      https://github.com/dyninst/dyninst/commit/ed5d37e721600566a1bd277529d4c298f638f712
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h

  Log Message:
  -----------
  Use x86_regpos_dword for 32-bit x86 registers


  Commit: b426333701f1fd971426be26d292faa3b57016d2
      https://github.com/dyninst/dyninst/commit/b426333701f1fd971426be26d292faa3b57016d2
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/x86.h
    M dataflowAPI/rose/registers/x86_64.h

  Log Message:
  -----------
  Make x86/x86_64 kmask 64-bit


  Commit: 87eb0239de4b41845993683a42c69cb7c6177fc6
      https://github.com/dyninst/dyninst/commit/87eb0239de4b41845993683a42c69cb7c6177fc6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/convert.C

  Log Message:
  -----------
  Preserve flag register parts


  Commit: 7a62f377fbc197638a4cdc74b4d61cbc93f3f1b1
      https://github.com/dyninst/dyninst/commit/7a62f377fbc197638a4cdc74b4d61cbc93f3f1b1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M dataflowAPI/rose/registers/convert.C

  Log Message:
  -----------
  Fix comment


  Commit: 281a0a34c52c63f888a42904cee1d6478833a73a
      https://github.com/dyninst/dyninst/commit/281a0a34c52c63f888a42904cee1d6478833a73a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M tests/CMakeLists.txt
    A tests/dataflowAPI/CMakeLists.txt
    A tests/dataflowAPI/rose/CMakeLists.txt
    A tests/dataflowAPI/rose/registers/CMakeLists.txt
    A tests/dataflowAPI/rose/registers/rose_reg_check.h
    A tests/dataflowAPI/rose/registers/x86.cpp
    A tests/dataflowAPI/rose/registers/x86_64.cpp

  Log Message:
  -----------
  Add unit tests


Compare: https://github.com/dyninst/dyninst/compare/aada2ddc49ed...281a0a34c52c

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 608e91: Correctly handle IP/PC for x86_64, Tim Haines <=