[DynInst_API:] [dyninst/dyninst] cee286: Operation_impl.h

Mailing List Archives Authenticated access	UW Madison Computer Sciences Department Computer Systems Lab
Date:	Sun, 10 Nov 2024 00:13:10 -0800
From:	Tim Haines <noreply@xxxxxxxxxx>
Subject:	[DynInst_API:] [dyninst/dyninst] cee286: Operation_impl.h - remove inline comments
  Branch: refs/heads/thaines/instructionapi_cleanup
  Home:   https://github.com/dyninst/dyninst
  Commit: cee286d57b49f8e133a82d20007f5e9127753a70
      https://github.com/dyninst/dyninst/commit/cee286d57b49f8e133a82d20007f5e9127753a70
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-09 (Sat, 09 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - remove inline comments

These are in the documentation (doc/API/Operation.tex), so don't need
to be duplicated here.


  Commit: a142540d44f04258706af38b432a4537d45cf86f
      https://github.com/dyninst/dyninst/commit/a142540d44f04258706af38b432a4537d45cf86f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-09 (Sat, 09 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - organize member functions

This visually groups them into their logical pairings.


  Commit: a6c5cdf96fbfe8a50df71fa0b10f7da91dbaf8d0
      https://github.com/dyninst/dyninst/commit/a6c5cdf96fbfe8a50df71fa0b10f7da91dbaf8d0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - whitespace


  Commit: 58aef400b311599cc032fcb32db0416f12a6c8f4
      https://github.com/dyninst/dyninst/commit/58aef400b311599cc032fcb32db0416f12a6c8f4
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - remove unneeded friend


  Commit: 4c110c586518c8ea42aa42d5c2be19039b4d3cb3
      https://github.com/dyninst/dyninst/commit/4c110c586518c8ea42aa42d5c2be19039b4d3cb3
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - remove lockable_adapter

It's unclear why this was ever added. No instances of this class are
used with a lock.


  Commit: 59cc1d228ea54b7f4c7580915b289962e977ec91
      https://github.com/dyninst/dyninst/commit/59cc1d228ea54b7f4c7580915b289962e977ec91
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/doc/API/Operation.tex
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - move extra comments to docs


  Commit: 19da549170653e5b2b1a2c0eff23a1fb7b34e665
      https://github.com/dyninst/dyninst/commit/19da549170653e5b2b1a2c0eff23a1fb7b34e665
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - use move in updateMnemonic


  Commit: f6ad073c3ce9c3c92771828676f14dbb73efbf73
      https://github.com/dyninst/dyninst/commit/f6ad073c3ce9c3c92771828676f14dbb73efbf73
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operation_impl.h

  Log Message:
  -----------
  Operation_impl.h - make protected members private

This class is never inherited from.


  Commit: c1849f72b6798494e4de38d9dc5054fd75cd99e3
      https://github.com/dyninst/dyninst/commit/c1849f72b6798494e4de38d9dc5054fd75cd99e3
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/doc/API/Instruction.tex
    M instructionAPI/h/Instruction.h

  Log Message:
  -----------
  Instruction.h - remove inline comments

These are in the documentation (doc/API/Instruction.tex), so don't need
to be duplicated here. There also seems to be drift, so the ones here
aren't complete or correct in all cases.


  Commit: a4be0c8f5c1b66a56cd0e0605afed9bd9fe35a6b
      https://github.com/dyninst/dyninst/commit/a4be0c8f5c1b66a56cd0e0605afed9bd9fe35a6b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Instruction.h

  Log Message:
  -----------
  Instruction.h - remove forward declaration of InstructionDecoder

It's never used


  Commit: 11495c0a5f88db49bb9f12f92282861a5e000db1
      https://github.com/dyninst/dyninst/commit/11495c0a5f88db49bb9f12f92282861a5e000db1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/doc/API/Instruction.tex
    M instructionAPI/h/Instruction.h

  Log Message:
  -----------
  Instruction.h - document getDisplayOrderedOperands


  Commit: 1b540c7464baf859d9fad32ea9f454917ccee6d5
      https://github.com/dyninst/dyninst/commit/1b540c7464baf859d9fad32ea9f454917ccee6d5
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Instruction.h

  Log Message:
  -----------
  Instruction.h - whitespace


  Commit: dc1a1d9bcb4f2ab53a2467e5280f64f7e3047599
      https://github.com/dyninst/dyninst/commit/dc1a1d9bcb4f2ab53a2467e5280f64f7e3047599
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Instruction.h
    M instructionAPI/src/Instruction.C

  Log Message:
  -----------
  Instruction - remove version function

It's never used and isn't in the docs. The CMake package offers a
cleaner way of determining version compatibility.


  Commit: bdfc11c5b6a5269cd693c0a4692dda691dbfa511
      https://github.com/dyninst/dyninst/commit/bdfc11c5b6a5269cd693c0a4692dda691dbfa511
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Instruction.h

  Log Message:
  -----------
  Instruction.h - organize member functions

This visually groups them into their logical pairings.


  Commit: 10f8d64cb2f2e4e2bbfa9e646cec7f96e9c9ced8
      https://github.com/dyninst/dyninst/commit/10f8d64cb2f2e4e2bbfa9e646cec7f96e9c9ced8
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/doc/API/Operand.tex
    M instructionAPI/h/Operand.h

  Log Message:
  -----------
  Operand.h - remove inline comments

These are in the documentation (doc/API/Operand.tex), so don't need
to be duplicated here.


  Commit: 7687054b99210e126b21950741c88da14517493d
      https://github.com/dyninst/dyninst/commit/7687054b99210e126b21950741c88da14517493d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operand.h

  Log Message:
  -----------
  Operand.h - whitespace


  Commit: abbc7e4a90ffd5a3f54086bb1c293d8da44683b0
      https://github.com/dyninst/dyninst/commit/abbc7e4a90ffd5a3f54086bb1c293d8da44683b0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operand.h

  Log Message:
  -----------
  Operand.h - organize member functions

This visually groups them into their logical pairings.


  Commit: d43a145bb16c683496679835ca3671da3c4c0d82
      https://github.com/dyninst/dyninst/commit/d43a145bb16c683496679835ca3671da3c4c0d82
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/src/Instruction.C

  Log Message:
  -----------
  Instruction.C - whitespace


  Commit: 9364b5b9538a4874b75fecb42329b661f5544069
      https://github.com/dyninst/dyninst/commit/9364b5b9538a4874b75fecb42329b661f5544069
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/src/Operand.C

  Log Message:
  -----------
  Operand.C - whitespace


  Commit: 6ea2495ebbb0a0b75d6a4ee6b744f51082364590
      https://github.com/dyninst/dyninst/commit/6ea2495ebbb0a0b75d6a4ee6b744f51082364590
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/src/Operation.C

  Log Message:
  -----------
  Operation.C - whitespace


  Commit: a3aeb085071faac5e3a06fc8000ff0c16869ff19
      https://github.com/dyninst/dyninst/commit/a3aeb085071faac5e3a06fc8000ff0c16869ff19
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/src/Instruction.C
    M instructionAPI/src/InstructionDecoder-x86.C
    M instructionAPI/src/Operation.C

  Log Message:
  -----------
  Remove INSIDE_INSTRUCTION_API macro

It's never used.


  Commit: 3ed1ca787844bce52b5a08856a75aad448419712
      https://github.com/dyninst/dyninst/commit/3ed1ca787844bce52b5a08856a75aad448419712
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operand.h

  Log Message:
  -----------
  Operand.h - remove setImplicit

It's never used and not documented. It makes no sense to change the implicitness of
an operation.


  Commit: 10979fa5da9062822064bf6035833fbc49951754
      https://github.com/dyninst/dyninst/commit/10979fa5da9062822064bf6035833fbc49951754
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Operand.h

  Log Message:
  -----------
  Operand.h - fix whitespace


  Commit: 1c76b094e309f75fb55b5f072f59af099376eb73
      https://github.com/dyninst/dyninst/commit/1c76b094e309f75fb55b5f072f59af099376eb73
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/h/Instruction.h
    M instructionAPI/src/Instruction.C

  Log Message:
  -----------
  Remove DEBUG_INSN_ALLOCATIONS

There isn't a CMake flag to enable it, and it's very doubtful anyone
is using -DCMAKE_CXX_FLAGS="-DDEBUG_INSN_ALLOCATIONS" to explicitly
enable it.


  Commit: 59600981113a668fa853fe2051a2e6063d633eef
      https://github.com/dyninst/dyninst/commit/59600981113a668fa853fe2051a2e6063d633eef
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M instructionAPI/src/Instruction.C

  Log Message:
  -----------
  Remove DEBUG_READ_WRITE

It's just leftover debug code. Users can fetch this information without enabling
this macro.


Compare: https://github.com/dyninst/dyninst/compare/cee286d57b49%5E...59600981113a

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread]	Current Thread	[Next in Thread→]
[DynInst_API:] [dyninst/dyninst] cee286: Operation_impl.h - remove inline comments, Tim Haines <=
Previous by Date:	[DynInst_API:] [dyninst/dyninst] 3534d5: Use correct ppc64 register in MachRegister::size(), Tim Haines
Next by Date:	[DynInst_API:] [dyninst/dyninst] 30c88f: Use correct ppc64 register in MachRegister::size()..., Tim Haines
Previous by Thread:	[DynInst_API:] [dyninst/dyninst] ce20ee: Rename callWritten -> callerSaved, Tim Haines
Next by Thread:	[DynInst_API:] [dyninst/dyninst] cf43cc: Disable init fini generation for AMD GPU, bbiiggppiigg
Indexes:	[Date] [Thread]
Mailing List Archives

Authenticated access

[DynInst_API:] [dyninst/dyninst] cee286: Operation_impl.h - remove inline comments
