[DynInst_API:] [dyninst/dyninst] cfa91d: Dead code cleanup (#1719)


Date: Tue, 26 Mar 2024 10:19:08 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] cfa91d: Dead code cleanup (#1719)
  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: cfa91d0260d40be1d7ee270e9d03567a56eefdad
      https://github.com/dyninst/dyninst/commit/cfa91d0260d40be1d7ee270e9d03567a56eefdad
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M common/h/Annotatable.h
    M common/src/Annotatable.C
    M common/src/arch-x86.C
    M common/src/freebsdHeaders.h
    M common/src/freebsdKludges.C
    M common/src/headers.h
    M common/src/linuxHeaders.h
    M common/src/linuxKludges.C
    M common/src/stats.C
    M common/src/stats.h
    M dataflowAPI/h/Absloc.h
    M dataflowAPI/src/Absloc.C
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/h/BPatch_function.h
    M dyninstAPI/h/BPatch_image.h
    M dyninstAPI/h/BPatch_module.h
    M dyninstAPI/h/BPatch_process.h
    M dyninstAPI/h/BPatch_snippet.h
    M dyninstAPI/src/BPatch_basicBlock.C
    M dyninstAPI/src/BPatch_basicBlockLoop.C
    M dyninstAPI/src/BPatch_function.C
    M dyninstAPI/src/BPatch_module.C
    M dyninstAPI/src/BPatch_snippet.C
    M dyninstAPI/src/Patching.C
    M dyninstAPI/src/Patching.h
    M dyninstAPI/src/Relocation/CodeBuffer.C
    M dyninstAPI/src/Relocation/Springboard.C
    M dyninstAPI/src/Relocation/Transformers/Movement-adhoc.C
    M dyninstAPI/src/Relocation/Transformers/Movement-analysis.C
    M dyninstAPI/src/Relocation/Widgets/CFWidget.C
    M dyninstAPI/src/StackMod/StackModChecker.C
    M dyninstAPI/src/addressSpace.C
    M dyninstAPI/src/ast.C
    M dyninstAPI/src/ast.h
    M dyninstAPI/src/codeRange.C
    M dyninstAPI/src/codegen-x86.C
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/emit-power.h
    M dyninstAPI/src/emit-x86.C
    M dyninstAPI/src/function.C
    M dyninstAPI/src/function.h
    M dyninstAPI/src/image.C
    M dyninstAPI/src/inst-aarch64.C
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI/src/instP.h
    M dyninstAPI/src/instPoint.C
    M dyninstAPI/src/linux-x86.C
    M dyninstAPI/src/mapped_module.C
    M dyninstAPI/src/mapped_module.h
    M dyninstAPI/src/mapped_object.h
    M dyninstAPI/src/parse-cfg.h
    M dyninstAPI/src/pcEventHandler.C
    R dyninstAPI/src/syscalltrap.h
    M dyninstAPI/src/unix.h
    M dyninstAPI/src/util.C
    M dyninstAPI/src/util.h
    M dyninstAPI_RT/src/RTcommon.c
    M dyninstAPI_RT/src/RTfreebsd.c
    M instructionAPI/h/Dereference.h
    M instructionAPI/h/Ternary.h
    M instructionAPI/h/Visitor.h
    M instructionAPI/src/Register.C
    M instructionAPI/src/Ternary.C
    M parseAPI/h/ParseContainers.h
    M parseAPI/src/IA_IAPI.C
    M parseAPI/src/IA_aarch64.C
    M parseAPI/src/IA_power.C
    M parseAPI/src/Parser.h
    M parseAPI/src/dominator.C
    M patchAPI/src/PatchBlock.C
    M proccontrol/CMakeLists.txt
    M proccontrol/h/ProcessSet.h
    M proccontrol/src/freebsd.C
    M proccontrol/src/int_thread_db.C
    M proccontrol/src/linux.C
    R proccontrol/src/notify_pipe.h
    M proccontrol/src/pcerrors.C
    M stackwalk/h/procstate.h
    M symtabAPI/doc/API/Symtab/Symbol.tex
    M symtabAPI/h/Function.h
    M symtabAPI/h/Symbol.h
    M symtabAPI/src/Function.C
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/Object-elf.h
    M symtabAPI/src/Symtab-lookup.C
    M symtabAPI/src/Symtab.C
    M symtabAPI/src/Type.C
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElfStatic-aarch64.C
    M symtabAPI/src/emitElfStatic-ppc64.C
    M symtabAPI/src/parseDwarf.C

  Log Message:
  -----------
  Dead code cleanup (#1719)

* Symtab.C

  376da2b61 in 2007
  b9ee0a524 in 2007
  4025acd83 in 2012
  4e4a375a4 in 2016
  85927e97f in 2017

* instPoint.C

  d8ade2 in 2011

* Absloc.h

  cd39a7 in 2010

* headers.h

  65bd80557 in 2008
  ac8f2817 in 2008

* inst-power.C

  3169f28af in 1995
  90afda5d4 in 2002
  8f5d555a0 in 2005
  7d4113393 in 2006
  bb377beb9 in 2007
  7e70f8ea2 in 2007
  41d0401ff in 2008
  e07d7ad2e in 2009
  62b7d1f21 in 2010
  fcd67b50c	in 2010
  1bdb443c7 in 2010
  b42dfb677 in 2011
  13eeea75f in 2012
  9fe681882 in 2012
  1ad3c5ead in 2018
	04c9b8706 in 2018

* Remove proccontrol/notify_pipe.h

  Added empty by ac7f7e2001 in 2010

* Remove dyninstAPI/src/syscalltrap.h

  Usage removed by 7a737b6a09e in 2010

* Absloc.C

  4aa8839d9 in 2010
  8ad73999f in 2010
  0b763f360 in 2010

  Technically an ABI/API break, but it's irrelevant since no one has been
  able to use those functions since 2010.

* ia32_is_mode_64

  556bc2b3a01b in 2017

* Ternary.C

  Not sure when this was removed

* TernaryAST::makePC

  Never implemented

* Register.C

  DEBUG added by e4173885 in 2010
  Debug printing removed by a4125a9e62a in 2011

* Visitor.h

  74a1da3143 in 2016

* ProcessSet.h

  Added by c9ec57036 in 2012, but never implemented

* symtabAPI/Function.h

  name_iter added by 7a3f133bc47 in 2016, but never used

* Symbol::getVersionNum(unsigned&) const

  Added by b3c1c8e4f in 2009, but never implemented

* ProcessState::setLibraryTracker(LibraryState *)

  Added by 10ca1b477 in 2009, but never implemented

* dyninstAPI/src/ast.h

  condMatch added by c79afe66f in 2001, but not implemented

  20116a1026 in 2006
  20116a1026 in 2007  
  fa14696b73 in 2009

* BPatch_image::findOrCreateVariable

  No implementation
  git has no record of this existing- even with a full pickaxe over
  the entire repo. I'd say it's ancient.

* BPatch_process::PDSEP_updateObservedCostAddr(unsigned long a)

  6293e88a8 in 2009

* BPatch_snippet::PDSEP_astMinCost()

  6293e88a8 in 2009

* CHECK_ALL_CALL_POINTS

  Last usage removed by 62b7d1f21 in 2009

* Remove decodeWaitPidStatus(procWaitpidStatus_t, EventRecord&)

  db6f2d307 in 2010

* Remove checkIfRelocatable(instruction, bool&)

  62b7d1f21 in 2010

* Remove parse_func::parseOMPSectFunc

  dee8900ad in 2011

* image.C

  80834b98d9 in 2005
  6d4e94744a in 2005
  75b6bee6b1 in 2005
  2fc202af93 in 2006
  6c65e3c9a8 in 2007
  74c0f96134 in 2008
  62b7d1f21d in 2010
  d66f3e0dcb in 2012

* dyninstAPI/src/util.h

  openFileWhenNotBusy: 23aaa1c7a in 2006
  waitForFileToExist:  e016bde56 in 2014
  uiHash:              f4613dcfe in 2008
  CThash:              7a737b6a0 in 2010
  intHash:             f8dda5e2d in 2010
  ptrHash4 added by 102d5c674 in 2005, but never implemented
  ptrHash16 added by 102d5c674 in 2005, but never implemented

* IA_aarch64.C

  Added by 0cbe6840935 in 2015, but never used
  0cbe684093 in 2015

* Parser::parse_sbp()

  bdb2cbdc8da in 2017

* Object::parseDwarfTypes(Symtab*)

  Disabled by 9c0aea7f1266d in 2012

* parseDwarf.C

  340799a201 in 2017

* BPatch_module::parseDwarfTypes()

  a3e86c198 in 2009

* Annotatable.C

  dummy_bs: 5eecdfe37 in 2009
  63c8f6a1fb in 2009
  3e890d05d7 in 2009
  'buffer' was added by 3e890d05d74 in 2009
  NON_STATIC_SPARSE_MAP, 3e890d05d74 in 2009

* ParseContainers.h

  d0fb605ef21 in 2012

* Remove emitStorePreviousStackFrameRegister

  usage removed by 4a4b40a24 in 2009,
  disabled by 90f965c1d in 2008

* emitElfStatic-aarch64.C

  AARCH64_WIDTH added by cf24b5261 in 2015, but never used
  OLD_VERSION added by f95525cbd in 2015

* emitElfStatic-ppc64.C

  5bc8d8877 in 2012
  0d6036621 in 2012
  760bfda6e in 2019
  ca68472cf in 2019
  x86 static vars added by aacf9a7c991 in 2012, but never used

* arch-x86.C

  e72838f1bc in 2016
  47b3368940 in 2016

* freebsdHeaders.h

  6647c9baa in 2010

* freebsdKludges.C

  ebd68e1b9 in 2012

* linuxHeaders.h

  dccf6451aa1 in 2006
  c51ddd7df17 in 1997

* stats.C

  3520f22bad3 in 2008

* BPatch_process.h

  3ca668c713 in 2012

* Movement-adhoc.C

  dd8f40b7b4 in 2012

* CFWidget.C

  b4d63301d1 in 2012
  758aa22669 in 2016

* Movement-analysis.C

  f891a319b in 2016

* linuxKludges.C

  839b81684 in 2007

* stats.h

  3520f22bad3 in 2008

* CFGWidget.C

  8bb4aa76a in 2011
  7ce20933e in 2011

* CodeBuffer.C

  94bceeffc8d in 2011

* Springboard.C

  fd362a2dff in 2012
  5a88f21a24 in 2018
  fb488fd49b in 2019
  8d9621ae21 in 2011

* inst-aarch64.C

  0cbe6840935 in 2015

* StackModChecker.C

  d0458f210b in 2015

* addressSpace.C

  c3fd2c456 in 2010
  fdc07b07e in 2011
  d0fb605ef in 2012
  5adcaef10 in 2012
  0efd04a78 in 2013
  827ad8e2e in 2015

* ast.C

  20116a1026 in 2006
  21d1427b92 in 2010
  4a4b40a242 in 2009

* BPatch_basicBlock.C

  0f5b6e43c in 2012
  d0fb605ef in 2012
  a91a2b261 in 2009

* BPatch_basicBlockLoop.C

  566ec0894c in 2012

* BPatch_function.C

  b66154964a in 2008

* BPatch_module.C

  d4b6dac19e4 in 2009
  0f2ad9bc29c in 2008

* BPatch_snippet.C

  23d4d4bb2 in 2009
  49ccad8e4 in 2011
  1c2eb3b7a in 2006

* codegen-x86.C

  041bad2f6 in 2015
  07c66053d in 2008
  c3fd2c456 in 2010
  da44e9b22 in 2006
  70328949c in 2011

* codeRange.C

  236581d63e in 2005
  0bce3c156c in 2006
  7a2dcd9df2 in 2010

* dynProcess.C

  9c63b2738d in 2012
  3faa4175c8 in 2012
  0efd04a781 in 2013
  0e791cce8c in 2015
  0f9e277665 in 2018

* emit-x86.C

  3173bd78e7 in 2011
  0cc0b67318 in 2012
  ab24c9bf00 in 2011

* func_instance::add_block_cb

  286b2a90835 in 2012

* instP.h

  8f5d555a082f in 2005

* Patching.h

  23f0550145 in 2011

* inst-x86.C

  f5943138c2 in 2010
  4322603c84 in 2004
  a7264f555f in 2010

* linux-x86.C

  db6f2d3076a in 2010

* mapped_module.C

  70328949c in 2011
  d2412c4d1 in 2011

* pcEventHandler.C

  0088b1285c in 2012
  4e1b40d005 in 2014  
  0e791cce8c in 2015

* RTcommon.C

  127dfc766 in 2010
  bd5874eef in 2010
  3717c253e in 2011
  1e2389977 in 2011  

* RTfreebsd.C

  d915f03b32 in 2012

* Dereference.h

  48f8d7b67b in 2016

* dominator.C

  ae9230394c in 2014

* IA_IAPI.C

  8cbd0fee4 in 2011
  f5e3d0030 in 2011

* IA_power.C

  641f99f4e in 2010
  5274e3bb2 in 2011
  2e0f15515 in 2011
  b0d83c42f in 2012

* PatchBlock.C

  f8842b40f6 in 2011

* freebsd.C

  9b1e7b5a2 in 2010
  d6399d41e in 2010

* int_thread_db.C

  f5e3492a81 in 2011

* linux.C

  579ba55f71 in 2011
  b0ced1cb30 in 2015
  bc243bcb9e in 2018  

* pcerrors.C

  b0ced1cb30 in 2015

* emitElf.C

  5bc8d8877 in 2012
  00098a1bb in 2016
  91bdb5e73 in 2016
  8c333ece5 in 2019
  4e14b3ebc in 2020

* symtabAPI/Function.C

  e1ed71e36c in 2009
  2ce1f7662c in 2015

* Object-elf.C

  a382e03ffa in 2012
  758aa22669 in 2016
  3a7d20c3f2 in 2017
  0600a498fd in 2017

* Symtab-lookup.C

  b82201865c in 2008
  dc7c82aa91 in 2012
  2d4c889dbb in 2018

* Type.C

  b9ee0a524 in 2007
  6a792a92a in 2008
  349d38cea in 2008
  3e890d05d in 2009
  d2e866379 in 2009



To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] cfa91d: Dead code cleanup (#1719), Tim Haines <=