[DynInst_API:] [dyninst/dyninst] ff4c71: Deprecate Symtab::getOrCreateModule

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/deprecate_symtab_getOrCreateModule
  Home:   https://github.com/dyninst/dyninst
  Commit: ff4c71ae9bbab380a5773c9d59f1f257f53b37f1
      https://github.com/dyninst/dyninst/commit/ff4c71ae9bbab380a5773c9d59f1f257f53b37f1
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M symtabAPI/h/Symtab.h

  Log Message:
  -----------
  Deprecate Symtab::getOrCreateModule

There are several problems here:

1) Users shouldn't be creating modules

2) When created, the returned module must be "fixed up" before it's
useful. There's no need for that when one could be properly constructed
at the callsite inside Dyninst.

3) It violates the Single Responsibility Principle


  Commit: 2d2af4bb69233de059fc23665d9e1ffe58877e11
      https://github.com/dyninst/dyninst/commit/2d2af4bb69233de059fc23665d9e1ffe58877e11
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M symtabAPI/h/Symtab.h
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/Object-elf.h
    M symtabAPI/src/Object.h
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Add Symtab::addModule

It's private, so can only be used by friends- specifically Object.


  Commit: fdd51334175532d4c3723cf655f4e9084fe55c8d
      https://github.com/dyninst/dyninst/commit/fdd51334175532d4c3723cf655f4e9084fe55c8d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Use addModule throughout Symtab


  Commit: 2a123abd71f6b4af02068015c1aa15024a9d8365
      https://github.com/dyninst/dyninst/commit/2a123abd71f6b4af02068015c1aa15024a9d8365
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Don't update mod_lookup_ in fixSymModules

The address ranges have already been inserted there by 'addModule'.


  Commit: 09a5ea2af4b2d02e000621b19d18b989c5b8cc79
      https://github.com/dyninst/dyninst/commit/09a5ea2af4b2d02e000621b19d18b989c5b8cc79
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M dyninstAPI/src/binaryEdit.C

  Log Message:
  -----------
  Use new check/add idiom for Modules in binaryEdit::writeFile


  Commit: 81e3e7a4eca9cf6747bf006444995c7ebf58b558
      https://github.com/dyninst/dyninst/commit/81e3e7a4eca9cf6747bf006444995c7ebf58b558
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M symtabAPI/src/Object-elf.C

  Log Message:
  -----------
  Use new idiom in Object::fix_global_symbol_modules_static_dwarf


Compare: https://github.com/dyninst/dyninst/compare/fe35179ed36e...81e3e7a4eca9