[DynInst_API:] [dyninst/dyninst] c22037: Clean up common/Types.h (#1619)

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: c22037820c37ada65d5478b09f4f353a663892ca
      https://github.com/dyninst/dyninst/commit/c22037820c37ada65d5478b09f4f353a663892ca
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M common/CMakeLists.txt
    M common/h/dyntypes.h
    M common/src/Graph.C
    M common/src/MappedFile.h
    M common/src/Timer.h
    R common/src/Types.C
    R common/src/Types.h
    M common/src/addrRange.h
    M common/src/addrtranslate-freebsd.C
    M common/src/addrtranslate-sysv.C
    M common/src/addrtranslate.h
    M common/src/arch-aarch64.C
    M common/src/arch-aarch64.h
    M common/src/arch-power.C
    M common/src/arch-power.h
    M common/src/arch-x86.C
    M common/src/arch-x86.h
    A common/src/dyn_register.h
    M common/src/freebsdKludges.C
    M common/src/freebsdKludges.h
    M common/src/headers.h
    M common/src/linuxHeaders.h
    M common/src/linuxKludges.C
    M common/src/linuxKludges.h
    M common/src/parseauxv.C
    M common/src/parseauxv.h
    M common/src/sha1.C
    A common/src/vm_maps.h
    M dataflowAPI/h/AbslocInterface.h
    M dataflowAPI/h/liveness.h
    M dataflowAPI/rose/semantics/SymEvalSemantics.C
    M dataflowAPI/rose/semantics/SymEvalSemantics.h
    M dataflowAPI/src/AbslocInterface.C
    M dataflowAPI/src/ExpressionConversionVisitor.C
    M dwarf/src/dwarfExprParser.C
    M dwarf/src/dwarfFrameParser.C
    M dwarf/src/dwarfResult.C
    M dynC_API/src/snippetGen.C
    M dyninstAPI/h/BPatch.h
    M dyninstAPI/h/BPatch_addressSpace.h
    M dyninstAPI/h/BPatch_basicBlock.h
    M dyninstAPI/h/BPatch_callbacks.h
    M dyninstAPI/h/BPatch_flowGraph.h
    M dyninstAPI/h/BPatch_function.h
    M dyninstAPI/h/BPatch_memoryAccess_NP.h
    M dyninstAPI/h/BPatch_point.h
    M dyninstAPI/h/BPatch_process.h
    M dyninstAPI/src/BPatch_basicBlock.C
    M dyninstAPI/src/BPatch_flowGraph.C
    M dyninstAPI/src/BPatch_function.C
    M dyninstAPI/src/BPatch_instruction.C
    M dyninstAPI/src/BPatch_libInfo.h
    M dyninstAPI/src/BPatch_memoryAccess.C
    M dyninstAPI/src/BPatch_memoryAccessAdapter.C
    M dyninstAPI/src/BPatch_memoryAccessAdapter.h
    M dyninstAPI/src/IAPI_to_AST.C
    M dyninstAPI/src/Parsing.h
    M dyninstAPI/src/RegisterConversion-aarch64.C
    M dyninstAPI/src/RegisterConversion-ppc.C
    M dyninstAPI/src/RegisterConversion-x86.C
    M dyninstAPI/src/RegisterConversion.h
    M dyninstAPI/src/Relocation/CFG/RelocBlock.h
    M dyninstAPI/src/Relocation/CodeMover.h
    M dyninstAPI/src/Relocation/DynPointMaker.C
    M dyninstAPI/src/Relocation/DynPointMaker.h
    M dyninstAPI/src/Relocation/Relocation.h
    M dyninstAPI/src/Relocation/Transformers/Transformer.h
    M dyninstAPI/src/Relocation/Widgets/PCWidget-ppc.C
    M dyninstAPI/src/Relocation/Widgets/PCWidget.h
    M dyninstAPI/src/Relocation/Widgets/Widget.h
    M dyninstAPI/src/StackMod/StackAccess.C
    M dyninstAPI/src/StackMod/StackLocation.h
    M dyninstAPI/src/addressSpace.h
    M dyninstAPI/src/ast.C
    M dyninstAPI/src/ast.h
    M dyninstAPI/src/baseTramp.C
    M dyninstAPI/src/baseTramp.h
    M dyninstAPI/src/codeRange.C
    M dyninstAPI/src/codeRange.h
    M dyninstAPI/src/codegen-aarch64.C
    M dyninstAPI/src/codegen-aarch64.h
    M dyninstAPI/src/codegen-power.C
    M dyninstAPI/src/codegen-power.h
    M dyninstAPI/src/codegen-x86.C
    M dyninstAPI/src/codegen-x86.h
    M dyninstAPI/src/codegen.C
    M dyninstAPI/src/codegen.h
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/dynProcess.h
    M dyninstAPI/src/emit-aarch64.C
    M dyninstAPI/src/emit-x86.C
    M dyninstAPI/src/frame.h
    M dyninstAPI/src/freebsd.h
    M dyninstAPI/src/function.h
    M dyninstAPI/src/image.h
    M dyninstAPI/src/infHeap.h
    M dyninstAPI/src/inst-aarch64.C
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI/src/inst-x86.h
    M dyninstAPI/src/inst.C
    M dyninstAPI/src/inst.h
    M dyninstAPI/src/instPoint.h
    M dyninstAPI/src/linux-aarch64.C
    M dyninstAPI/src/linux-aarch64.h
    M dyninstAPI/src/linux-power.C
    M dyninstAPI/src/linux-power.h
    M dyninstAPI/src/linux-x86.C
    M dyninstAPI/src/linux.h
    M dyninstAPI/src/mapped_module.h
    M dyninstAPI/src/mapped_object.h
    M dyninstAPI/src/os.h
    M dyninstAPI/src/parRegion.C
    M dyninstAPI/src/parRegion.h
    M dyninstAPI/src/parse-cfg.h
    M dyninstAPI/src/patch.h
    M dyninstAPI/src/pcEventHandler.h
    M dyninstAPI/src/pcEventMuxer.C
    M dyninstAPI/src/pcEventMuxer.h
    M dyninstAPI/src/pcrel.h
    M dyninstAPI/src/pdwinnt.C
    M dyninstAPI/src/registerSpace.C
    M dyninstAPI/src/registerSpace.h
    M dyninstAPI/src/syscalltrap.h
    M dyninstAPI/src/trapMappings.h
    M dyninstAPI/src/util.h
    M dyninstAPI_RT/h/dyninstAPI_RT.h
    M dyninstAPI_RT/src/RTheap-linux.c
    M dyninstAPI_RT/src/RTheap.h
    M instructionAPI/src/Instruction.C
    M instructionAPI/src/InstructionDecoder-power.C
    M instructionAPI/src/InstructionDecoder-x86.C
    M instructionAPI/src/Operation.C
    M parseAPI/src/IA_IAPI.C
    M parseAPI/src/IA_aarch64.C
    M parseAPI/src/IA_amdgpu.C
    M parseAPI/src/IA_power.C
    M parseAPI/src/IA_x86.C
    M parseAPI/src/IndirectAnalyzer.C
    M parseAPI/src/InstructionAdapter.C
    M parseAPI/src/SymtabCodeSource.C
    M patchAPI/h/AddrSpace.h
    M patchAPI/h/Point.h
    M patchAPI/src/AddrSpace.C
    M patchAPI/src/Point.C
    M patchAPI/src/PointMaker.C
    M proccontrol/src/int_thread_db.C
    M proccontrol/src/linux.C
    M proccontrol/src/loadLibrary/codegen-aarch64.C
    M proccontrol/src/mmapalloc.C
    M proccontrol/src/procset.C
    M proccontrol/src/sysv.C
    M proccontrol/src/unix.C
    M stackwalk/src/analysis_stepper.C
    M stackwalk/src/callchecker-IAPI.C
    M stackwalk/src/dbginfo-stepper.C
    M stackwalk/src/freebsd-swk.h
    M stackwalk/src/freebsd-x86-swk.C
    M stackwalk/src/linux-swk.h
    M stackwalk/src/linux-x86-swk.C
    M stackwalk/src/linuxbsd-swk.C
    M stackwalk/src/linuxbsd-swk.h
    M stackwalk/src/linuxbsd-x86-swk.C
    M stackwalk/src/x86-wanderer.C
    M symlite/src/SymLite-elf.C
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/Object-elf.h
    M symtabAPI/src/Object-nt.h
    M symtabAPI/src/emitElf.h
    M symtabAPI/src/indexed_symbols.hpp

  Log Message:
  -----------
  Clean up common/Types.h (#1619)

* Move definition of Dyninst::ThrIDToTid into common/dyntypes.h

59ddf22 in 2009, this function was changed to always just return an int-like representation of 'id'.

* Move Address_str into dynProcess.C

It's only ever used there.

* Remove Address_chk

It is never used.

* Remove common/src/Types.C

All of the definitions have been removed/relocated.

* Remove unused time64 declaration

* Remove unused Word type

* Remove hash_address from Types.h

It's not used.

* Explicitly use namespace for read_memory_as

* Merge Address definition and variable decls

* Remove unused includes of common/Types.h

* Add Dyninst namespace directive in arch-x86.C

It was transitively included from common/Types.h.

* Move Register type into its own file

* Rename NULL_REG -> Null_Register

No need to have two names for the same value.

* Put Register, RegVal, and Null_Register in Dyninst namespace

* Move map_entries into its own file

* Remove common/Types.h

* Fixes for ppc

* Use Dyninst::Address in codegen-aarch64

* Use Dyninst::Register in codegen-aarch64

* Simplify Address_str

Address is a typedef to an unsigned long on all platforms. No need for
the other case.

* Use Dyninst::Address in dynProcess.C