[DynInst_API:] [dyninst/dyninst] cf4dc1: Fix astOperatorNode semantics (#1621)

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: cf4dc1383a34dfc900e974424bca64b5af5e5ad0
      https://github.com/dyninst/dyninst/commit/cf4dc1383a34dfc900e974424bca64b5af5e5ad0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M dyninstAPI/src/ast.C

  Log Message:
  -----------
  Fix astOperatorNode semantics (#1621)

* Revert "Guarantee operands in AstOperatorNode are non-null (#1609)"

This reverts commit 9fa5f6dc0307d735700c544ca83d661926b40803.

* Fix loperand

* Use tighter checks on roperand in generateCode_phase2

* Remove useless checks in generateCode_phase2

Variables are used before checked.

* Remove AstOperatorNode default ctor

* Remove ~AstOperatorNode

* Remove assert on loperand

It's checked on line 1303.

* Add more loperand checks