[DynInst_API:] [dyninst/dyninst] 6d5057: Merge getOrCreateModule and newModule

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/refactor_symtab_getOrCreateModule
  Home:   https://github.com/dyninst/dyninst
  Commit: 6d505771c480ae2e25fb388ce656a42a168187ea
      https://github.com/dyninst/dyninst/commit/6d505771c480ae2e25fb388ce656a42a168187ea
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Merge getOrCreateModule and newModule

The latter was only ever called from the former.


  Commit: 5492702438bbc0204b14608aa812488fb275d6a6
      https://github.com/dyninst/dyninst/commit/5492702438bbc0204b14608aa812488fb275d6a6
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove dead debug code


  Commit: 6d3494e2d3dc4143db69f643df4dbada74cb0c13
      https://github.com/dyninst/dyninst/commit/6d3494e2d3dc4143db69f643df4dbada74cb0c13
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Do not adjust Module's address

It's unclear why this was here. This function is currently called from
only two places: BinaryEdit::writeFile and
Object::fix_global_symbol_modules_static_dwarf.

In the first, the module created is called 'dyninstInst'. This is the
only place where that name is used, so only one module would be created.
Moreover, 'writeFile' will only produce a single binary output, so there
wouldn't be multiple modules.

In the second, the module lookup will always fail because we are
creating new ones for each DWARF compilation unit (CU), and those are
guaranteed to be unique as we iterate over the results of
'dwarf_nextcu'.


  Commit: ad013afd0388207d453203b016cf9a3954dd6d68
      https://github.com/dyninst/dyninst/commit/ad013afd0388207d453203b016cf9a3954dd6d68
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove 'directory definitions' check

This kind of name is never used manually anywhere in Dyninst and the
names that come from DWARF compilation units (CUs) are never
directories.


  Commit: 2c8ceb6778e984c9ee985f4b1971e1c4bc4a4837
      https://github.com/dyninst/dyninst/commit/2c8ceb6778e984c9ee985f4b1971e1c4bc4a4837
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Clean up 'create' tracing message


  Commit: f154421269818a0131419c4bfb7d8e0a7478a891
      https://github.com/dyninst/dyninst/commit/f154421269818a0131419c4bfb7d8e0a7478a891
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Tidy up variable declarations.


  Commit: a11c46a558ede210145de03e59c17810864faafb
      https://github.com/dyninst/dyninst/commit/a11c46a558ede210145de03e59c17810864faafb
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove 'assert' after 'new'.

We require exceptions to be enabled when building Dyninst and we aren't
using the 'nothrow' version of 'operator new' here. This check is
useless.


  Commit: 63afcee7f24be5f36b9bdd05b5c6be605a9d7900
      https://github.com/dyninst/dyninst/commit/63afcee7f24be5f36b9bdd05b5c6be605a9d7900
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove existence check.

This will never be true because 'findModuleByOffset' would have found
the module.


  Commit: 78dff28893ff6763337f31b015ba8de6ff4edbcc
      https://github.com/dyninst/dyninst/commit/78dff28893ff6763337f31b015ba8de6ff4edbcc
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Don't return with parens


  Commit: 0ebf3069090586d842cdc8f402c686ff7f5cdd4f
      https://github.com/dyninst/dyninst/commit/0ebf3069090586d842cdc8f402c686ff7f5cdd4f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Rename 'ret' to 'mod'.

For clarity.


Compare: https://github.com/dyninst/dyninst/compare/97d144347d39...0ebf30690905