[DynInst_API:] [dyninst/dyninst] 7c971e: Unify naming of Modules


Date: Thu, 07 Sep 2023 10:10:31 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 7c971e: Unify naming of Modules
  Branch: refs/heads/thaines/unify_symtab_module_naming
  Home:   https://github.com/dyninst/dyninst
  Commit: 7c971e8e01919081e5f403fa75dc05de8bee5619
      https://github.com/dyninst/dyninst/commit/7c971e8e01919081e5f403fa75dc05de8bee5619
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.hpp
    A dwarf/h/dwarf_names.hpp
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Unify naming of Modules

There are currently several different techniques being used
inconsistently to name Modules. This unifies all of these techniques
and applies them consistently.


  Commit: ddb50d13ea72eb3909ce40921457ba54ea3045ca
      https://github.com/dyninst/dyninst/commit/ddb50d13ea72eb3909ce40921457ba54ea3045ca
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.hpp
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Unify naming type units

This also refers to DW_FORM_ref_sig8 types by their names in
sig8_type_ids_ rather than reinterpret_cast-ing them from a char* to
a uint64_t which is UB.


  Commit: 59a32755ae151066bfd5e71d4120d64f9537370e
      https://github.com/dyninst/dyninst/commit/59a32755ae151066bfd5e71d4120d64f9537370e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dyninstAPI/src/BPatch_image.C
    M dyninstAPI/src/mapped_object.C
    M symtabAPI/doc/3-Examples.tex
    M symtabAPI/h/Aggregate.h
    M symtabAPI/src/Aggregate.C
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove DEFAULT_MODULE

Because every Module now has a unique name, it's no longer possible to
execute this code path.

The 'pmodule' class uses the name from the Module class (see the
pmodule constructor).


  Commit: 9ac415f70121c3a41cc0c787abf687af31b3c565
      https://github.com/dyninst/dyninst/commit/9ac415f70121c3a41cc0c787abf687af31b3c565
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.hpp
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Revert "Unify naming type units"

It's not clear from the DWARF std at this time if dwarf_formstring
will actually return the signature/MD5 hash for a type unit. Whatever
the old code has done is likely broken, so we don't want to propagate
that here. Likely, the DW_FORM_ref_sig8 parsing isn't being done
correctly overall, and will need to be fixed in the future.

This reverts commit 8a32113cddb2beb7cd5e3fc42221be098a76a602.


  Commit: a12488497f66f79c676329d9ea535f92a82fc7ff
      https://github.com/dyninst/dyninst/commit/a12488497f66f79c676329d9ea535f92a82fc7ff
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    A dwarf/h/dwarf_cu_info.h
    R dwarf/h/dwarf_cu_info.hpp
    A dwarf/h/dwarf_names.h
    R dwarf/h/dwarf_names.hpp

  Log Message:
  -----------
  Rename .hpp to .h

For consistency.


  Commit: bd10c29de55a7964f6f3a5cd02c29e8a5cb2a932
      https://github.com/dyninst/dyninst/commit/bd10c29de55a7964f6f3a5cd02c29e8a5cb2a932
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.h
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Add copyright headers


  Commit: 52f0bedce23929819befac983dbe672b2f64028c
      https://github.com/dyninst/dyninst/commit/52f0bedce23929819befac983dbe672b2f64028c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Check for empty base path in detail::absolute_path


  Commit: 46d167f89d69f8d4dbc2dc0b69bcd22e75c97e3e
      https://github.com/dyninst/dyninst/commit/46d167f89d69f8d4dbc2dc0b69bcd22e75c97e3e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.h
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/dwarfWalker.C

  Log Message:
  -----------
  Use renamed files


  Commit: 8ea522bd2cd9d8dba120a3429b1908ce8021dc55
      https://github.com/dyninst/dyninst/commit/8ea522bd2cd9d8dba120a3429b1908ce8021dc55
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  add missing include


  Commit: 7dc28853029543e2c4682e84404702c2bc68458d
      https://github.com/dyninst/dyninst/commit/7dc28853029543e2c4682e84404702c2bc68458d
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Add hex prefix when computing detail::die_offset


  Commit: 68422ba951cfb61975137712a2c8410ef5ccfc40
      https://github.com/dyninst/dyninst/commit/68422ba951cfb61975137712a2c8410ef5ccfc40
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.h
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Don't name anonymous DIEs

Many DIEs don't have names (e.g., type decorator definitions like
DW_TAG_pointer_type), but DwarfWalker has explicit checks for these
cases (DwarfWalker::nameDefined).


Compare: https://github.com/dyninst/dyninst/compare/1763b899c090...68422ba951cf
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 7c971e: Unify naming of Modules, Tim Haines <=