[DynInst_API:] [dyninst/dyninst] 636007: Fix responsibility inversion in Module::finalizeRa...


Date: Tue, 05 Sep 2023 19:48:57 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 636007: Fix responsibility inversion in Module::finalizeRa...
  Branch: refs/heads/thaines/unify_symtab_module_naming
  Home:   https://github.com/dyninst/dyninst
  Commit: 63600787a5ff07d1fdc03835c3fcb99731e65a9a
      https://github.com/dyninst/dyninst/commit/63600787a5ff07d1fdc03835c3fcb99731e65a9a
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M symtabAPI/h/Module.h
    M symtabAPI/src/Module.C
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Fix responsibility inversion in Module::finalizeRanges (#1498)

A Module shouldn't modify the Symtab object to which it belongs. It
knows what ranges belong to it (see
Object::fix_global_symbol_modules_static_dwarf), so it can munge them
into a collection of `ModRange`s.

The `ranges_finalized` member was never needed as the only place
it was set was in `finalizeRanges` which is the only place where
`ranges` was emptied.


  Commit: c78306758207a1dce4bd7d292d1c3a6b29dede1b
      https://github.com/dyninst/dyninst/commit/c78306758207a1dce4bd7d292d1c3a6b29dede1b
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M symtabAPI/h/Module.h
    M symtabAPI/src/Module.C
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Merge branch 'master' into thaines/unify_symtab_module_naming


  Commit: 46c250b8b6028b8206533dde1453b11ebf06ebe7
      https://github.com/dyninst/dyninst/commit/46c250b8b6028b8206533dde1453b11ebf06ebe7
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.hpp
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Revert "Unify naming type units"

It's not clear from the DWARF std at this time if dwarf_formstring
will actually return the signature/MD5 hash for a type unit. Whatever
the old code has done is likely broken, so we don't want to propagate
that here. Likely, the DW_FORM_ref_sig8 parsing isn't being done
correctly overall, and will need to be fixed in the future.

This reverts commit 8a32113cddb2beb7cd5e3fc42221be098a76a602.


  Commit: 860553e2473f6215deced4455508f70fa52aed04
      https://github.com/dyninst/dyninst/commit/860553e2473f6215deced4455508f70fa52aed04
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    A dwarf/h/dwarf_cu_info.h
    R dwarf/h/dwarf_cu_info.hpp
    A dwarf/h/dwarf_names.h
    R dwarf/h/dwarf_names.hpp

  Log Message:
  -----------
  Rename .hpp to .h

For consistency.


  Commit: 2ab3467fbf8f0d7501cfce7eb95b059589bfab74
      https://github.com/dyninst/dyninst/commit/2ab3467fbf8f0d7501cfce7eb95b059589bfab74
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.h
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Add copyright headers


  Commit: 6e03d20b78cad698ae720cc56b7dd94404951042
      https://github.com/dyninst/dyninst/commit/6e03d20b78cad698ae720cc56b7dd94404951042
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M dwarf/h/dwarf_names.h

  Log Message:
  -----------
  Check for empty base path in detail::absolute_path


Compare: https://github.com/dyninst/dyninst/compare/f82554e8b5d0...6e03d20b78ca
[← Prev in Thread] Current Thread [Next in Thread→]