[DynInst_API:] [dyninst/dyninst] 57b0fd: Unify naming of Modules


Date: Thu, 31 Aug 2023 20:52:31 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 57b0fd: Unify naming of Modules
  Branch: refs/heads/thaines/unify_symtab_module_naming
  Home:   https://github.com/dyninst/dyninst
  Commit: 57b0fdaafbfefe809d85ab876e487e5c9a50dbf3
      https://github.com/dyninst/dyninst/commit/57b0fdaafbfefe809d85ab876e487e5c9a50dbf3
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M dwarf/h/dwarf_cu_info.hpp
    A dwarf/h/dwarf_names.hpp
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Unify naming of Modules

There are currently several different techniques being used
inconsistently to name Modules. This unifies all of these techniques
and applies them consistently.


  Commit: 8a32113cddb2beb7cd5e3fc42221be098a76a602
      https://github.com/dyninst/dyninst/commit/8a32113cddb2beb7cd5e3fc42221be098a76a602
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M dwarf/h/dwarf_names.hpp
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Unify naming type units

This also refers to DW_FORM_ref_sig8 types by their names in
sig8_type_ids_ rather than reinterpret_cast-ing them from a char* to
a uint64_t which is UB.


  Commit: f82554e8b5d09a3274e7ea6947e1d3cfeb0f973c
      https://github.com/dyninst/dyninst/commit/f82554e8b5d09a3274e7ea6947e1d3cfeb0f973c
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M dyninstAPI/src/BPatch_image.C
    M dyninstAPI/src/mapped_object.C
    M symtabAPI/doc/3-Examples.tex
    M symtabAPI/h/Aggregate.h
    M symtabAPI/src/Aggregate.C
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove DEFAULT_MODULE

Because every Module now has a unique name, it's no longer possible to
execute this code path.

The 'pmodule' class uses the name from the Module class (see the
pmodule constructor).


Compare: https://github.com/dyninst/dyninst/compare/57b0fdaafbfe%5E...f82554e8b5d0
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 57b0fd: Unify naming of Modules, Tim Haines <=