[DynInst_API:] [dyninst/dyninst] 369ec2: Remove AObject::symsToModules_ (#1488)

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 369ec2d033d4554229d5e9228acdeb68791b1f85
      https://github.com/dyninst/dyninst/commit/369ec2d033d4554229d5e9228acdeb68791b1f85
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
    M symtabAPI/src/Object-elf.C
    M symtabAPI/src/Object-elf.h
    M symtabAPI/src/Object-nt.C
    M symtabAPI/src/Object.C
    M symtabAPI/src/Object.h
    M symtabAPI/src/Symtab.C

  Log Message:
  -----------
  Remove AObject::symsToModules_ (#1488)

* Remove AObject::findModuleForSym

Its usage was removed by 4e4a375a4 in 2016.

* Remove AObject::setModuleForOffset

Its usage was removed by 0e5d83405 in 2016.

* Remove use of AObject::symsToModules_ in Object-nt

It is only ever written to, and its usage was removed by 4e4a375a4
in 2016.

* Remove use of AObject::symsToModules_ in Object-elf

It is only ever written to, and its usage was removed by 4e4a375a4
in 2016.

* Remove unused parameters and variables

These are no longer needed.