[DynInst_API:] [dyninst/dyninst] 70fe64: Shifting signed 32-bit value by 31 bits is undefin...

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/fix_int_ub
  Home:   https://github.com/dyninst/dyninst
  Commit: 70fe64c52eef87303761e4e7f63dda35e18b5444
      https://github.com/dyninst/dyninst/commit/70fe64c52eef87303761e4e7f63dda35e18b5444
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M instructionAPI/src/InstructionDecoder-aarch64.C
    M patchAPI/h/Point.h

  Log Message:
  -----------
  Shifting signed 32-bit value by 31 bits is undefined behavior

This was found using cppcheck's shiftTooManyBitsSigned.


  Commit: 68926736c3115b90e3c469ff10f4ff6645c4aee0
      https://github.com/dyninst/dyninst/commit/68926736c3115b90e3c469ff10f4ff6645c4aee0
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M parseAPI/src/Block.C
    M parseAPI/src/Function.C

  Log Message:
  -----------
  Signed to unsigned conversion in calculation

These were found using cppcheck's signConversion.


  Commit: 6d4a58e1b83d4620e323eb35a67cee7e7d3e9be4
      https://github.com/dyninst/dyninst/commit/6d4a58e1b83d4620e323eb35a67cee7e7d3e9be4
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M proccontrol/src/x86_process.C

  Log Message:
  -----------
  Fix signed overflow

This was found using cppcheck's integerOverflowCond.


  Commit: 2be00d4c3767a7805a1d53a64730a872fb149124
      https://github.com/dyninst/dyninst/commit/2be00d4c3767a7805a1d53a64730a872fb149124
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M dyninstAPI/src/codegen-power.C

  Log Message:
  -----------
  Shifting negative value

This was found using cppcheck's shiftNegativeLHS.


Compare: https://github.com/dyninst/dyninst/compare/70fe64c52eef%5E...2be00d4c3767