[DynInst_API:] [dyninst/dyninst] 2f7af1: Fix link bug in insnCodeGen::loadImmIntoReg on aar...


Date: Mon, 03 Apr 2023 19:12:15 -0700
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 2f7af1: Fix link bug in insnCodeGen::loadImmIntoReg on aar...
  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 2f7af10477b0f7daf0efca2c992224711e5deb27
      https://github.com/dyninst/dyninst/commit/2f7af10477b0f7daf0efca2c992224711e5deb27
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M dyninstAPI/src/codegen-aarch64.C
    M dyninstAPI/src/codegen-aarch64.h
    M dyninstAPI/src/emit-aarch64.C
    M dyninstAPI/src/inst-aarch64.C

  Log Message:
  -----------
  Fix link bug in insnCodeGen::loadImmIntoReg on aarch64 (#1405)

* Fix link bug in insnCodeGen::loadImmIntoReg on aarch64

The function template has a separate declaration and "definition" AND is
called from translation units where neither is located. This only happens
to work correctly when the TUs are linked in a specific order.

* Remove assert

The value is now always positive.

* Remove missed template usage in emit-aarch64.C


[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 2f7af1: Fix link bug in insnCodeGen::loadImmIntoReg on aar..., Tim Haines <=