[DynInst_API:] [dyninst/dyninst] 42c3a4: Fix virtual derived signature to match base class


Date: Tue, 28 Feb 2023 15:55:10 -0800
From: Bolo -- Josef Burger <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 42c3a4: Fix virtual derived signature to match base class
  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: 42c3a4b497071e421686ded49ad0da406c8053ac
      https://github.com/dyninst/dyninst/commit/42c3a4b497071e421686ded49ad0da406c8053ac
  Author: wuxx1279 <bbiiggppiigg@xxxxxxxxx>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.C
    M instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
    M instructionAPI/src/AMDGPU/gfx908/InstructionDecoder-amdgpu-gfx908.C
    M instructionAPI/src/AMDGPU/gfx908/InstructionDecoder-amdgpu-gfx908.h

  Log Message:
  -----------
  Fix virtual derived signature to match base class

makeRegisterExpression in the derived class had
an incorrect function signature, which made
compilation fails on gcc-6 and clang.


  Commit: 557a01949a4c11e8e8975fe113e4ab07b64bf25d
      https://github.com/dyninst/dyninst/commit/557a01949a4c11e8e8975fe113e4ab07b64bf25d
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
    M instructionAPI/src/AMDGPU/gfx908/InstructionDecoder-amdgpu-gfx908.h

  Log Message:
  -----------
  add InstructionDecoderImpl::makeRegisterExpression to derived classes

Eliminate virtual-overloaded warning as there are 3 overloaded methods of
InstructionDecoderImpl::makeRegisterExpression, but only 2 are defined in
these classes for add a using so the 3rd is not hidden.


  Commit: f89cc72416fdc1d467b130f48609b8fc93126d37
      https://github.com/dyninst/dyninst/commit/f89cc72416fdc1d467b130f48609b8fc93126d37
  Author: Bolo -- Josef Burger <bigtrak@xxxxxxxxxxxxxxxxxxxxxxxx>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.C
    M instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
    M instructionAPI/src/AMDGPU/gfx908/InstructionDecoder-amdgpu-gfx908.C
    M instructionAPI/src/AMDGPU/gfx908/InstructionDecoder-amdgpu-gfx908.h

  Log Message:
  -----------
  Merge pull request #1389 from dyninst/wuxx1279/gfx908/clang-error

Fix ambiguous override of InstructionDecoder_amdgpu_*::makeRegisterExpression


Compare: https://github.com/dyninst/dyninst/compare/9d15c0f71439...f89cc72416fd
[← Prev in Thread] Current Thread [Next in Thread→]