[DynInst_API:] [dyninst/dyninst] ac658d: Replace DwarfWalker::findString with DwarfWalker::...


Date: Thu, 09 Feb 2023 08:05:25 -0800
From: Tim Haines <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] ac658d: Replace DwarfWalker::findString with DwarfWalker::...
  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: ac658dea96f755e21b6256f74007157be54e745e
      https://github.com/dyninst/dyninst/commit/ac658dea96f755e21b6256f74007157be54e745e
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M symtabAPI/src/dwarfWalker.C
    M symtabAPI/src/dwarfWalker.h

  Log Message:
  -----------
  Replace DwarfWalker::findString with DwarfWalker::find_call_file (#1360)

The original function was only ever used to find DW_AT_call_file. During
the transition to libdw, the added check for that attribute made the
rest of the string processing useless. Moreover, the code update also
introduced a bug in checking the return value of dwarf_whatform which
rendered the function completely useless as a generic stringform parser.


[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] ac658d: Replace DwarfWalker::findString with DwarfWalker::..., Tim Haines <=